Model first-party pull request synchronization builds - #355
Open
sj26 wants to merge 2 commits into
Open
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a01c65-f65e-7751-b99c-7c9a8c43cfb0 Co-authored-by: Samuel Cochran <sj26@sj26.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a01c65-f65e-7751-b99c-7c9a8c43cfb0 Co-authored-by: Samuel Cochran <sj26@sj26.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Buildkite's GitHub integration coalesces first-party
pull_request.synchronizedeliveries into linked push builds enriched with pull request metadata. buildkite-gha treatedBUILDKITE_GITHUB_EVENT=pushas authoritative, so a workflow with filteredpushandpull_requesttriggers selected the push context and rejected the feature branch. Rebuilds without linked push metadata selected the pull request context instead, producing inconsistent results.This was reproduced by sj26/mailcatcher Buildkite build #31.
What
pull_request/synchronizeevent using trusted Buildkite head and base metadata.push, partition generated conditions so the event groups cannot overlap, and preserve Buildkite repository, commit, and checkout authority.