PB-3032: Snapshot checkout contracts per commit - #347
Open
zhming0 wants to merge 1 commit into
Open
Conversation
Admit frozen actions/checkout tag and release-branch history through generated per-commit contracts. Preserve declared inputs, runner-plugin fetch defaults, and output availability while continuing to reject future unknown commits. Amp-Thread-ID: https://ampcode.com/threads/T-01a01dd0-0453-7533-9505-6a8f4296dda7 Co-authored-by: Ming Guo <ming@buildkite.com>
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Workflows pinned to historical
actions/checkoutcommits fail when those commits fall outside the current release andmainsnapshots. Blanket future admission is compatibility-unsafe even though the native adapter never executes upstream code: declared inputs, defaults, and outputs changed between commits.Closes PB-3032.
What
main,master, andreleases/v1throughreleases/v6, covering 254 SHAs across 16 contracts—159 more SHAs than before.refandcommitoutputs only when the manifest declares both. This corrects the previous pre-v4.2 output classification.mise run checkpasses, including tests, race tests, lint, vet, local smoke checks, and release validation.