fix: replace through2 with native stream.Transform - #70
Merged
Conversation
through2 v5 is ESM-only with no CJS compat layer; require('through2')
no longer works. Since every usage was through2.obj(transform, flush),
which is exactly new Transform({ objectMode: true, transform, flush }),
drop the dependency entirely in favor of Node's built-in stream module.
Also fixes the pre-existing typo in client.js (though2 → Transform).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
through2v5 went ESM-only (#118) with no CJS compat layer —require('through2')no longer resolves, breaking lint and teststhrough2.obj(transform, flush), which is exactlynew Transform({ objectMode: true, transform, flush })from Node's built-instreamthrough2fromdependenciesentirely; no new deps, no behaviour changesrc/client.js(though2→Transform)Closes / supersedes dependabot PR #69.
Files changed
src/server.jsrequire('through2')→require('stream').Transform,through2.obj()→new Transform(...)src/client.jsthough2typotests/utils/logStream.jstests/index.nonRx.spec.jsexamples/helloworld/impls/server.jspackage.jsonthrough2fromdependenciesTest plan
npm run lint— cleannpm test— 5/5 files, 41/41 tests pass (2 pre-existing skips)🤖 Generated with Claude Code