Skip to content

fix FormulaAudit/CMakeArgs style offenses - #2342

Merged
YoshitakaMo merged 1 commit into
brewsci:developfrom
BenjaminDEMAILLE:fix-cmake-style
Aug 30, 2026
Merged

fix FormulaAudit/CMakeArgs style offenses#2342
YoshitakaMo merged 1 commit into
brewsci:developfrom
BenjaminDEMAILLE:fix-cmake-style

Conversation

@BenjaminDEMAILLE

Copy link
Copy Markdown
Contributor

brew style brewsci/bio currently fails on develop, so every open PR against this tap goes red on --only-tap-syntax regardless of what it changes:

354 files inspected, 21 offenses detected, 21 offenses autocorrectable
FormulaAudit/CMakeArgs: Use explicit `-S` and `-B` arguments for CMake.

This applies brew style --fix. All 21 corrections are one-liners and semantics-preserving, because the rule keeps the existing source and build directories rather than relocating them:

# inside mkdir "build" do
- system "cmake", "..", *std_cmake_args
+ system "cmake", "-S", "..", "-B", ".", *std_cmake_args

- system "cmake", ".", *std_cmake_args
+ system "cmake", "-S", ".", "-B", ".", *std_cmake_args

brew style . is clean afterwards (354 files, no offenses). I built and tested one of the touched formulae to confirm nothing moved:

brew install --build-from-source brewsci/bio/fastq-pair   # cmake -S .. -B . → ok
brew test brewsci/bio/fastq-pair                          # ok

No revision bumps, since nothing about the installed output changes.

Worth knowing before merging: because 21 formula files are touched, CI will want to rebuild bottles for all of them, which may surface unrelated pre-existing build failures. Happy to split this per formula, or to reduce it to only the files needed to get brew style green, if you would rather.

AI-assisted: the autocorrect run, the verification build and this description were produced with Claude Code and reviewed by me before opening.

@YoshitakaMo
YoshitakaMo merged commit e2520a7 into brewsci:develop Aug 30, 2026
2 of 5 checks passed
@BenjaminDEMAILLE
BenjaminDEMAILLE deleted the fix-cmake-style branch August 30, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants