Skip to content

feat: Added file type filtering to slashcommand attachments - #1630

Merged
braindigitalis merged 3 commits into
brainboxdotcc:devfrom
Henonicks:attach-rest
Aug 1, 2026
Merged

feat: Added file type filtering to slashcommand attachments#1630
braindigitalis merged 3 commits into
brainboxdotcc:devfrom
Henonicks:attach-rest

Conversation

@Henonicks

Copy link
Copy Markdown
Contributor

Discord's adding a new file type filtering feature to slashcommands and components: discord/discord-api-docs#8506
I'm implementing this change here

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify

netlify Bot commented Aug 1, 2026

Copy link
Copy Markdown

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit dca0745
🔍 Latest deploy log https://app.netlify.com/projects/dpp-dev/deploys/6a6e14bd3b84a7000807a0dd
😎 Deploy Preview https://deploy-preview-1630--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Henonicks

Copy link
Copy Markdown
Contributor Author

I tested this build with slashcommands and while the json I'm sending looks right, it's accepting a .cpp file. Does Discord actually have this feature already?
Also, where in D++ is the component --> json conversion in case its type is dpp::cot_file_upload? I can't find it

^ hence why this PR is a draft at the moment

@github-actions github-actions Bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Aug 1, 2026
@Henonicks
Henonicks marked this pull request as ready for review August 1, 2026 15:46
@Henonicks

Copy link
Copy Markdown
Contributor Author

Seems like it should work but Discord hasn't launched the change yet. Also dpp::component has been taken care of. Therefore, I'm ready for review.

@braindigitalis braindigitalis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@braindigitalis
braindigitalis merged commit a321b50 into brainboxdotcc:dev Aug 1, 2026
41 checks passed
@Henonicks
Henonicks deleted the attach-rest branch August 9, 2026 14:21
@Henonicks
Henonicks restored the attach-rest branch August 9, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants