fix(order-stream): make WebSocket cleanup generation-aware - #2067
Open
grandpig wants to merge 1 commit into
Open
fix(order-stream): make WebSocket cleanup generation-aware#2067grandpig wants to merge 1 commit into
grandpig wants to merge 1 commit into
Conversation
Signed-off-by: grandpig <grandpig@outlook.com>
grandpig
requested review from
a team,
capossele,
jonastheis,
nahoc,
unizarr and
zeroecco
as code owners
August 3, 2026 16:43
Author
|
@capossele Just following up on this in case it got buried. This fixes the reconnect cleanup race so a stale WebSocket task can't remove its replacement connection, including the same race in broadcast cleanup. Deterministic regression tests are included. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make WebSocket connection cleanup identity-aware.
Fixes #2066
Why
Connection cleanup currently removes entries by address only. When a client reconnects with the same address, cleanup from the previous connection can remove the replacement connection. Broadcast cleanup has the same race.
Changes
Testing
cargo test -p order-stream