Bring Galilean PIM in line with templated IMU preintegration - #2759
Merged
Conversation
dellaert
force-pushed
the
codex/galilean-pim-template
branch
from
August 28, 2026 19:02
0ec3a57 to
f3ecf89
Compare
7d1983fa4 Merge pull request #208 from borglab/codex/typedef-serialization 7059bae4f Support serialization metadata on template typedefs git-subtree-dir: wrap git-subtree-split: 7d1983fa4fee70cededa4d43915333dde83e6e9a
dellaert
force-pushed
the
codex/galilean-pim-template
branch
2 times, most recently
from
August 29, 2026 16:08
5daeb8d to
69ccb9f
Compare
Member
Author
|
@rohan-bansal will merge but if you see any issues just comment and ping me on slack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GalileanPreintegrationand definePreintegratedImuMeasurementsGasPreintegratedImuMeasurementsT<GalileanPreintegration>Performance
The Galilean hot-path microbenchmarks improved approximately as follows:
0.99 usto0.56 usper sample158 nsto115 ns1235 nsto954 nsAnalytical outputs and Jacobians are unchanged.
Wrapper behavior
Python and MATLAB expose
PreintegratedImuMeasurementsGthrough the same template/typedef machinery as the other preintegration backends. The generated wrapper includes the standard PIM methods and serialization without registering a duplicate native type.Compatibility
PreintegratedImuMeasurements,ImuFactor, andImuFactor2construction, serialization, naming, and APIs remain supportedTesting
testGalileanImuFactor.runtestSerializationNavigation.runpy312environmentgtsam_matlab_wrappergenerated and compiledgit diff --checkCloses #2756