Fix shared pointer handling in MATLAB bindings - #2725
Closed
ProfFan wants to merge 1 commit into
Closed
Conversation
Use the wrapper pointer DSL consistently for shared ownership and add named stereo measurement and calibration vector bindings with Python and MATLAB lifetime coverage. The MATLAB generator fix lives upstream in borglab/wrap#200.
ProfFan
force-pushed
the
fix/matlab-shared-pointer-codegen
branch
from
August 21, 2026 22:58
d0ce487 to
1bf85a1
Compare
Member
|
OK, hold up. The reason the signatures changed was that we could then use pointers instead of lambdas. That only works if the signatures are identical, so I had a PR in wrap (that can still be merged) that takes these identical signatures. I think you wanted to look into an alternative PR in wrap, but if you want to use method pointers, I think you will need those identical signatures unless you have an other mechanism that doesn’t care about this. discuss :-) |
Member
|
Would you also be good to say what prompted this PR, for history’s sake |
Collaborator
Author
|
This is not needed because we have another path which is let wrap directly support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency
Depends on borglab/wrap#200 for the MATLAB shared-pointer property-setter generator fix. This PR intentionally contains no direct wrap subtree changes.
Testing