Fix China Done freezing on a hidden deck - #153
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a two-player China game, clicking Done after the last player's building turn could freeze the browser before the move reached BGS. The viewer replays its turn buffer with the hidden deck removed; China's market refill kept calling
addPowerPlantuntil two plants appeared, even though the empty deck could never supply them.Stop the refill when no cards remain. Normal server-side draws are unchanged, and the viewer continues to wait for the authoritative result of the committing move.
Validation:
The fix must be included when rebuilding and publishing the viewer: its local engine replay is where this game freezes. No live game state was changed or deployment performed.