Skip to content

Fix unsoundness in JsValueStore by replacing unsafe raw pointer mutation of Arc with safe OnceLock - #5408

Closed
mansiverma897993 wants to merge 2 commits into
boa-dev:mainfrom
mansiverma897993:fix/unsound-jsvaluestore-replace
Closed

Fix unsoundness in JsValueStore by replacing unsafe raw pointer mutation of Arc with safe OnceLock#5408
mansiverma897993 wants to merge 2 commits into
boa-dev:mainfrom
mansiverma897993:fix/unsound-jsvaluestore-replace

chore: fix clippy lints for the Rust 1.98 toolchain

357b23d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 26, 2026 in 0s

62.81% (+15.57%) compared to 6ddc2b4

View this Pull Request on Codecov

62.81% (+15.57%) compared to 6ddc2b4

Details

Codecov Report

❌ Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.81%. Comparing base (6ddc2b4) to head (357b23d).
⚠️ Report is 1019 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/module/loader/mod.rs 0.00% 3 Missing ⚠️
core/runtime/src/fetch/fetchers.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5408       +/-   ##
===========================================
+ Coverage   47.24%   62.81%   +15.57%     
===========================================
  Files         476      530       +54     
  Lines       46892    59108    +12216     
===========================================
+ Hits        22154    37130    +14976     
+ Misses      24738    21978     -2760     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.