Skip to content

add URLSearchParams support - #5040

Merged
jedel1043 merged 11 commits into
boa-dev:mainfrom
Monti-27:url-searchparams-clean
Sep 1, 2026
Merged

add URLSearchParams support#5040
jedel1043 merged 11 commits into
boa-dev:mainfrom
Monti-27:url-searchparams-clean

Conversation

@Monti-27

@Monti-27 Monti-27 commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Fixes #4743.

Adds URLSearchParams and wires up URL.searchParams.

This also fixes the constructor path for iterable inputs, handles explicit undefined correctly in the two-argument has() and delete() overloads, adds runtime coverage, and re-enables the skipped URL WPT case.

Tests:

  • cargo test -p boa_runtime --lib
  • cargo test --manifest-path tests/wpt/Cargo.toml url -- --nocapture
  • cargo clippy -p boa_runtime --all-features --all-targets -- -D warnings

@github-actions

github-actions Bot commented Mar 13, 2026

Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 52,963 52,963 0
Passed 50,073 49,935 -138
Ignored 2,072 2,207 +135
Failed 818 821 +3
Panics 0 0 0
Conformance 94.54% 94.28% -0.26%
Broken tests (3):
test/intl402/DateTimeFormat/prototype/toStringTag/toStringTag.js (previously Passed)
test/intl402/DateTimeFormat/prototype/toStringTag/toString.js (previously Passed)
test/intl402/Number/prototype/toLocaleString/throws-same-exceptions-as-NumberFormat.js (previously Passed)

Tested main commit: 0698e7063866a1b40be043a1089be43d3224db4b
Tested PR commit: a594311f4748c1f5461953ea54b30877a73f8538
Compare commits: 0698e70...a594311

@Monti-27 Monti-27 closed this Mar 13, 2026
@Monti-27
Monti-27 deleted the url-searchparams-clean branch March 13, 2026 17:18
@Monti-27 Monti-27 reopened this Mar 13, 2026
@Monti-27 Monti-27 changed the title Implement URL.searchParams and URLSearchParams add URLSearchParams support Mar 13, 2026
@Monti-27

Monti-27 commented Mar 14, 2026

Copy link
Copy Markdown
Contributor Author

@jedel1043 can you please review this
thank you !!

Comment thread core/runtime/src/url.rs Outdated
@jedel1043 jedel1043 added A-Enhancement New feature or request Waiting On Author Waiting on PR changes from the author C-Runtime Issues and PRs related to Boa's runtime features labels Mar 16, 2026
@github-actions github-actions Bot added Waiting On Review Waiting on reviews from the maintainers C-Tests Issues and PRs related to the tests. C-Builtins PRs and Issues related to builtins/intrinsics and removed Waiting On Review Waiting on reviews from the maintainers labels Mar 17, 2026
@Monti-27

Copy link
Copy Markdown
Contributor Author

@jedel1043 updated this. searchParams is now created during URL construction and the getter just returns the same object.

@Monti-27
Monti-27 requested a review from jedel1043 March 17, 2026 17:41
Comment thread core/runtime/src/url.rs Outdated
Comment thread core/runtime/src/url.rs
Comment thread core/runtime/src/url.rs
Comment thread core/runtime/src/url.rs Outdated
@Monti-27

Copy link
Copy Markdown
Contributor Author

give me 5 mins I'll clutch this :))

@Monti-27
Monti-27 requested a review from jedel1043 March 17, 2026 19:03
@Monti-27

Copy link
Copy Markdown
Contributor Author

also fixed the clippy failure from the missing errors docs on the Rust side URL constructors

Comment thread core/runtime/src/url.rs
@jedel1043 jedel1043 added Waiting On Review Waiting on reviews from the maintainers and removed Waiting On Author Waiting on PR changes from the author labels Mar 18, 2026
@Monti-27
Monti-27 requested a review from jedel1043 March 18, 2026 14:49
@codecov

codecov Bot commented Mar 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.79279% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.66%. Comparing base (6ddc2b4) to head (fddf67a).
⚠️ Report is 1038 commits behind head on main.

Files with missing lines Patch % Lines
core/runtime/src/url.rs 92.72% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5040       +/-   ##
===========================================
+ Coverage   47.24%   62.66%   +15.41%     
===========================================
  Files         476      534       +58     
  Lines       46892    59878    +12986     
===========================================
+ Hits        22154    37521    +15367     
+ Misses      24738    22357     -2381     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jedel1043 jedel1043 added Waiting On Author Waiting on PR changes from the author and removed Waiting On Review Waiting on reviews from the maintainers labels Mar 18, 2026
@github-actions

github-actions Bot commented Mar 19, 2026

Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 53,578 53,578 0
Passed 51,326 51,326 0
Ignored 1,748 1,748 0
Failed 504 504 0
Panics 0 0 0
Conformance 95.80% 95.80% 0.00%

Tested main commit: 598d1841b5dd9495ed0375885e36ce4011cf44bb
Tested PR commit: fddf67aab8fce3ebb43474d701a7cf09c31f7191
Compare commits: 598d184...fddf67a

@jedel1043 jedel1043 removed the C-Builtins PRs and Issues related to builtins/intrinsics label Mar 20, 2026
Comment thread core/runtime/src/url.rs Outdated
@github-actions github-actions Bot added the C-Builtins PRs and Issues related to builtins/intrinsics label Apr 8, 2026
@Monti-27
Monti-27 requested a review from jedel1043 April 8, 2026 19:05
@Monti-27

Copy link
Copy Markdown
Contributor Author

@hansl your thoughts on this

@tomasol

tomasol commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

I find this feature very useful. Are there any blockers or can it be merged?

@Monti-27

Copy link
Copy Markdown
Contributor Author

@jedel1043 PTAL

@hansl

hansl commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

This LGTM, @jedel1043 should also do a last pass of review.

@jedel1043 jedel1043 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jedel1043
jedel1043 added this pull request to the merge queue Aug 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 30, 2026
@Monti-27

Copy link
Copy Markdown
Contributor Author

this break after v0.22 was released. I’m updating Url to preserve its existing traits, then I’ll rerun the checks

@Monti-27
Monti-27 force-pushed the url-searchparams-clean branch from 1f11a4a to d0bd512 Compare August 30, 2026 20:19
@Monti-27
Monti-27 requested review from hansl and jedel1043 August 30, 2026 21:05
@jedel1043
jedel1043 added this pull request to the merge queue Sep 1, 2026
Merged via the queue into boa-dev:main with commit 8a506c8 Sep 1, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Enhancement New feature or request C-Builtins PRs and Issues related to builtins/intrinsics C-Runtime Issues and PRs related to Boa's runtime features C-Tests Issues and PRs related to the tests. Waiting On Author Waiting on PR changes from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement URLSearchParams class

4 participants