Skip to content

feat: Add OnFinality as RPC provider - #874

Open
HuberTRoy wants to merge 1 commit into
bnb-chain:mainfrom
HuberTRoy:main
Open

feat: Add OnFinality as RPC provider#874
HuberTRoy wants to merge 1 commit into
bnb-chain:mainfrom
HuberTRoy:main

Conversation

@HuberTRoy

Copy link
Copy Markdown

OnFinality provides public BNB Smart Chain RPC infrastructure and can be used as an additional endpoint option for developers and applications interacting with BNB Chain.

Changes

  • Added OnFinality to the BNB Smart Chain RPC provider list
  • Added the public BNB Smart Chain RPC endpoint
  • Followed the existing provider format used in this repository

The endpoint has been tested and is publicly accessible.

@hashdit-bot

hashdit-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

Pull Request Review

This PR adds OnFinality as a public BNB Smart Chain JSON-RPC endpoint and lists it among supported RPC providers. The changes are applied consistently across the primary documentation and the two consolidated LLM documentation files.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@Faiqonli

Copy link
Copy Markdown

Thanks for adding OnFinality as an RPC provider and including the public endpoint.

Before merging, please confirm / address these quick checks:

  1. Secrets: Verify the added endpoint URL does not include any API keys, tokens, or other credentials. If a secret is required, remove it from the repo and use a secure configuration method instead.
  2. Reachability (add a reproducible smoke test): show the command you used to verify the endpoint is reachable. Example smoke test reviewers can run:
curl -sS -o /dev/null -w "%{http_code}\n" "https://bnb.api.onfinality.io/public"

(Expect a successful HTTP status or a documented expected response; include the observed status in the PR description or commit message.)
3. Docs / changelog: Add or update a short note in provider docs or CHANGELOG mentioning OnFinality was added as a public endpoint.
4. Reliability (optional): If this endpoint may be used in production, consider adding an alternative/failover endpoint or a short note about availability/SLA.

If you can confirm 1 and add the small verification note from 2, I'll approve this for merge.

@@ -57,6 +58,8 @@ You could find more endpoints from **[here](https://chainlist.org/chain/56)**.

* **dRPC:** <https://drpc.org/chainlist/bsc>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0x14e58750ccd6c95becd1279d2a0373b507701c40

@mamunkhan637-cmd

Copy link
Copy Markdown

0x14e58750ccd6c95becd1279d2a0373b507701c40
This Wallet Why not Showing Many Tokens Funds in Screen I can't understand 😭

@HuberTRoy

Copy link
Copy Markdown
Author

@Faiqonli
Hello, thanks your review, here are the additional details:

  1. Secrets

I confirm that https://bnb.api.onfinality.io/public is a public endpoint and does not include any API keys, tokens, or other credentials.

  1. Reachability
    Since this is a JSON-RPC endpoint, I tested it with valid JSON-RPC POST requests rather than a plain GET request.
curl -sS -o /dev/null -w "%{http_code}\n" \
  -H "Content-Type: application/json" \
  --data '{"jsonrpc":"2.0","method":"eth_chainId","params":[],"id":1}' \
  "https://bnb.api.onfinality.io/public"
curl -sS -o /dev/null -w "%{http_code}\n" \
  -H "Content-Type: application/json" \
  --data '{"jsonrpc":"2.0","method":"eth_blockNumber","params":[],"id":1}' \
  "https://bnb.api.onfinality.io/public"

I tested both from my local machine in Hong Kong and from a server in France. Both locations returned:
200

image image
  1. Reliability
    CompareNodes also lists OnFinality as a BSC RPC provider:
    https://www.comparenodes.com/protocols/bsc/#providers

For production usage, an authenticated OnFinality endpoint with an API key is recommended over relying solely on the public endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants