Skip to content

Add GitHub Actions workflow for Jekyll site CI - #841

Open
adfjadfj16-a11y wants to merge 118 commits into
bnb-chain:feat-add-gnfd-deposit-instfrom
adfjadfj16-a11y:main
Open

Add GitHub Actions workflow for Jekyll site CI#841
adfjadfj16-a11y wants to merge 118 commits into
bnb-chain:feat-add-gnfd-deposit-instfrom
adfjadfj16-a11y:main

Conversation

@adfjadfj16-a11y

Copy link
Copy Markdown

No description provided.

annielz and others added 30 commits May 19, 2025 10:12
…-inst

feat: add deposit instruction in greenfield faq
0xlucasliao and others added 21 commits March 2, 2026 22:14
Update docs to use a lowercased skills.md reference and streamline the AI skills page. Changed links in docs/showcase/mcp/index.md and mkdocs.yml to point to ./showcase/mcp/skills.md, simplified docs/showcase/mcp/SKILLS.md by removing the community skills table, updating the manual curl link to the lowercased path, and renumbering the Agent registration section. This normalizes the filename casing and removes outdated content.
Revise and reorganize MCP Skills documentation and navigation
* The block time has changed from 1 second to 250 ms

* bsc block time is now 750ms and opBNB block time is 250ms

* bsc block time is 0.45 seconds not 0.75s

* bsc has a gas limit of 55M, opBNB 50M

* Active validator set is 45 (21 “Cabinet” + 24 “Candidates”), not 32.

* Updated RPC URL from .binance to .bnbchain

* Updated RPC URL from .binance to .bnbchain

* Corrected wrong bsc block time as well as updated current gas price and avg transaction cost

* Correcting block time and finality

* updated transaction cost as gas price has reduced

* Updated standard gas price

* updated rpc url from .binance to .bnbchain

* testnet gas fee change
* docs: add llms.txt exports for AI context

Made-with: Cursor

* Update docs/llms.txt

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update docs/llms.txt

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update docs/llms-full-bnb-smart-chain.txt

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Gwen-M <188413625+Gwen-M@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Update faucet docs to explain how to request tBNB via the official Discord server or the Telegram support bot (@bnbchain_official_bot). Adds an example request format and states the daily limit of 0.3 tBNB. Removes the old note about not receiving tBNB when wallet balance exceeds 1 tBNB and the previous deprecated Discord faucet message.
…hannels

Add Discord/Telegram tBNB request instructions
Update docs/bnb-smart-chain/validator/mev/user-guide.md to replace the Blocksmith entry with JetBuilder in the list of private privacy-protecting RPC service providers and update the provider link to JetBuilder's API. Keeps the provider list up to date.
Replace Blocksmith with JetBuilder in MEV guide
Reorganize documentation to centralize SDK/API content under a new Developer Kit section. Updated the Greenfield APIs & SDKs landing page to point to /developer-kit/ and removed legacy Greenfield SDK pages (sdk-go.md, sdk-js.md). Added new developer-kit pages (ask-ai, bnbagent-sdk, greenfield-sdk, mcp, mpp-sdk, index). Moved MCP skills doc into the developer-kit path and updated various Greenfield guides and quick-starts. Removed many outdated showcase pages and large image assets (tokenization, identity, MCP showcase, etc.) to reduce clutter. Also updated mkdocs.yml and refreshed llms docs. These changes consolidate developer-facing resources and trim deprecated/showcase content.
Introduce comprehensive BNBAgent SDK documentation (index, architecture, configuration, quickstart, examples, networks, and related pages) and update the Developer Kit index. Add Ask AI quickstart rewrite and a VS Code walkthrough with annotated screenshots. Add MPP SDK ADRs and docs, various new developer-kit pages, showcase images, small copy edits to Greenfield/opBNB/BSC quick guides, update llms.txt, and adjust mkdocs.yml to include the new content.
Add a new BNBChain Studio docs set (architecture, CLI reference, demo, deployment, quickstart, security, troubleshooting, index, config and many demo images) and adjust site configuration. Refresh BNBAgent SDK docs: clarify wording, remove hard-coded on-chain addresses in favor of upstream deployment links, update example links and placeholders, and tighten security/signing docs to reference runtime-resolved settlement assets. Small site fixes: CSS tweaks for inline code in links, fix Ask AI VS Code guide image paths and contact instructions, remove two mpp-sdk docs, update llms.txt and mkdocs.yml. Overall: introduce studio docs and harmonize developer docs and assets.
Update BNBAgent SDK docs to clarify that ERC-8004 registration can be gas-sponsored via MegaFuel on both BSC Testnet and BSC Mainnet. Changes in docs/developer-kit/bnbagent-sdk/index.md, docs/developer-kit/bnbagent-sdk/networks.md, and docs/developer-kit/bnbchain-studio/demo.md: clarify gas-free registration wording, separate general testnet faucet guidance from ERC-8004 sponsorship, and update demo instructions to mention Mainnet sponsorship as well. This reduces confusion about where MegaFuel paymaster sponsorship is available.
Completely rewrites docs/developer-kit/bnbchain-studio/demo.md to replace static screenshots with detailed interactive transcripts and step-by-step guidance. Adds expanded instructions for installation, bag init usage, wallet creation, funding, LLM activation, local testing (bag dev), ERC-8183/ERC-8004 flows, Secrets Manager guidance, and AWS deploy readiness. Also updates the demo fund screenshot asset (docs/assets/developer-kit/bnbchain-studio/demo/fund-2.png).
@hashdit-bot

hashdit-bot Bot commented Jun 22, 2026

Copy link
Copy Markdown

Pull Request Review

This PR adds a new GitHub Actions workflow (.github/workflows/jekyll-docker.yml) to run CI for a Jekyll site on pushes and pull requests targeting main. The workflow checks out the repository and builds the site inside the jekyll/builder:latest Docker container, mounting the workspace and _site directories. It also applies broad write permissions (chmod -R 777) to the mounted project directory before building.

Sensitive Content

No sensitive content detected.

Security Issues

🟠 [HIGH] Insecure CI build due to unpinned mutable Docker image tag

File: .github/workflows/jekyll-docker.yml
The workflow uses jekyll/builder:latest, which is a mutable tag. If the upstream image changes or is compromised, unreviewed code could execute in CI with repository context, creating a supply-chain risk.
Recommendation: Pin the image to an immutable digest (e.g., jekyll/builder@sha256:...) or at minimum a fixed version tag, and update it intentionally via reviewed PRs.

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@hashdit-bot

hashdit-bot Bot commented Jul 5, 2026

Copy link
Copy Markdown

Pull Request Review

This PR adds a new GitHub Actions workflow to build the Jekyll site on pushes and pull requests targeting main using the jekyll/builder:latest Docker image. It also introduces a new Spanish README (README_ES.md) with project overview, setup steps, contribution guidance, and useful BNB Chain links. Overall, the changes are focused on CI setup and documentation localization.

Sensitive Content

No sensitive content detected.

Security Issues

🟠 [HIGH] Insecure CI build step uses world-writable permissions on repository workspace

File: .github/workflows/jekyll-docker.yml
The workflow executes chmod -R 777 /srv/jekyll inside the container while mounting the repository workspace. Making the entire workspace world-writable is an unsafe practice that can enable unexpected file tampering during CI execution and weakens build integrity guarantees.
Recommendation: Remove chmod -R 777 and use least-privilege permissions (e.g., ensure correct owner/group for needed paths only, or set targeted writable directories with minimal modes such as 755/775 where necessary).

🟠 [HIGH] Unpinned mutable Docker image tag in CI (latest)

File: .github/workflows/jekyll-docker.yml
The workflow pulls jekyll/builder:latest, which is mutable and can change without notice. This introduces a supply-chain risk where future image updates could alter or compromise CI behavior unexpectedly.
Recommendation: Pin the Docker image to an immutable digest (e.g., jekyll/builder@sha256:...) or at least a fixed, reviewed version tag and update it through controlled dependency maintenance.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@hashdit-bot

hashdit-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

Pull Request Review

This PR adds a GitHub Actions workflow that installs Ruby dependencies, builds and validates the Jekyll site, and uploads the generated site as an artifact. It also introduces a Spanish README containing an overview of BNB Chain, local setup instructions, contribution guidance, and official resources.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@adfjadfj16-a11y
adfjadfj16-a11y changed the base branch from main to feat-add-gnfd-deposit-inst July 26, 2026 11:42

@adfjadfj16-a11y adfjadfj16-a11y left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finalizado

Comment thread docs/bc-fusion/post-fusion/token-recovery.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.