Skip to content

bump deps: spirit (+parser), golang, linter - #22

Merged
morgo merged 2 commits into
block:mainfrom
morgo:bump-deps
Aug 19, 2026
Merged

bump deps: spirit (+parser), golang, linter#22
morgo merged 2 commits into
block:mainfrom
morgo:bump-deps

Conversation

@morgo

@morgo morgo commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI lite review requested due to automatic review settings August 19, 2026 13:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates dependency/tooling versions and migrates SQL parsing from TiDB’s parser to Spirit’s parser, updating query formatting expectations accordingly.

Changes:

  • Switch pkg/query parsing imports from github.com/pingcap/tidb/pkg/parser to github.com/block/spirit/pkg/parser (and related ast/format/mysql packages).
  • Update query validation and tests to use shared AST-to-string restoration (restoreString), reflecting the new canonical formatting output.
  • Bump Go/tooling/deps (Go 1.26.6, kong/testify/spirit, plus updated hermit pkg wrappers for Go and golangci-lint).

Reviewed changes

Copilot reviewed 5 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/query/validator.go Uses restoreString to extract WHERE clause (new canonical formatting path).
pkg/query/validator_test.go Updates expected WHERE formatting to match Spirit parser restore output.
pkg/query/parse.go Swaps SQL parser implementation to Spirit’s parser packages.
pkg/query/expression_folder.go Updates parser/format imports and adjusts unfoldable function list for new AST package.
go.mod Bumps Go version and updates key deps (spirit/kong/testify) while removing TiDB parser dependency.
go.sum Updates module checksums consistent with dependency bumps/removals.
bin/.golangci-lint-2.12.2.pkg Adds hermit-generated wrapper for golangci-lint version bump.
bin/.go-1.26.6.pkg Adds hermit-generated wrapper for Go version bump.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pkg/query/validator.go
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@morgo
morgo enabled auto-merge August 19, 2026 13:32
@morgo
morgo merged commit 1255cfb into block:main Aug 19, 2026
8 checks passed
@morgo
morgo deleted the bump-deps branch August 19, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants