Skip to content

send queued messages in the background when the chat is not open #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morgmart merged 3 commits into from
Aug 15, 2026
Merged

send queued messages in the background when the chat is not open #41

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
096f448
Send queued messages in the background when the chat is not open
tulsi-builder Aug 14, 2026
c82e1ff
Harden background queue drain from review findings
tulsi-builder Aug 14, 2026
ce14a6e
Fix overlapping queue reclaim reconciliation
morgmart Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/SessionWindowApp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import {
} from "@/features/chat/stores/sessionWindowStore";
import { useBerdctlQueuedMessageDrain } from "@/features/berdctl/bridge/useBerdctlQueuedMessageDrain";
import { ChatView } from "@/features/chat/ui/ChatView";
import { ReleasedQueuedMessageDrain } from "@/features/chat/ui/ReleasedQueuedMessageDrain";
import { BackgroundQueuedMessageDrain } from "@/features/chat/ui/BackgroundQueuedMessageDrain";
import { useWorkspaceNameRequestQueue } from "@/features/chat/hooks/useWorkspaceNameRequestQueue";
import { ProjectWorkspaceStartupNameDialog } from "@/features/projects/ui/ProjectWorkspaceStartupNameDialog";
import { Button } from "@/shared/ui/button";
Expand Down Expand Up @@ -437,7 +437,7 @@ export function SessionWindowApp({

return (
<>
<ReleasedQueuedMessageDrain
<BackgroundQueuedMessageDrain
sessionId={sessionId}
ownerReady={phase === "ready"}
/>
Expand Down
8 changes: 4 additions & 4 deletions src/app/main.berdctl.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,15 +101,15 @@ describe("main entrypoint berdctl bridge loading", () => {
const sessionBranch = mainSource.slice(sessionBranchStart, mainBranchStart);
const mainBranch = mainSource.slice(mainBranchStart);
expect(sessionBranch).not.toContain("<OptionalBerdctlBridge />");
expect(mainBranch).toContain("<ReleasedQueuedMessageDrain />");
expect(mainBranch).toContain("<BackgroundQueuedMessageDrain />");
expect(mainBranch).toContain("<OptionalBerdctlBridge />");
});

it("mounts the released queued-message drain unconditionally", () => {
it("mounts the background queued-message drain unconditionally", () => {
expect(mainSource).toContain(
'import { ReleasedQueuedMessageDrain } from "@/features/chat/ui/ReleasedQueuedMessageDrain"',
'import { BackgroundQueuedMessageDrain } from "@/features/chat/ui/BackgroundQueuedMessageDrain"',
);
expect(mainSource).not.toContain("OptionalReleasedQueuedMessageDrain");
expect(mainSource).not.toContain("OptionalBackgroundQueuedMessageDrain");
});

it("reports a failed dynamic bridge import without boot-failing the app", () => {
Expand Down
12 changes: 1 addition & 11 deletions src/features/berdctl/commands/runtime/sessionSend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ export {
SessionDispatchUnresolvedError,
} from "@/features/chat/lib/queuedSessionSend";
import { formatIncludedWorkspacesPrompt } from "@/features/chat/lib/workspaceAttachments";
import type { QueuedMessageRecord } from "@/features/chat/stores/chatStore";
import type { MessageMetadata } from "@/shared/types/messages";
import type { ChatSendOptions } from "@/features/chat/types";
export { isBerdctlCrossSessionQueuedMessage } from "@/features/chat/lib/queuedMessageOrigin";

export const BERDCTL_CROSS_SESSION_ORIGIN =
"berdctl_cross_session" satisfies NonNullable<MessageMetadata["origin"]>;
Expand All @@ -32,16 +32,6 @@ export function berdctlCrossSessionSendOptions(): ChatSendOptions {
};
}

export function isBerdctlCrossSessionQueuedMessage(
message: QueuedMessageRecord | undefined,
): boolean {
return (
message?.kind === "transport-ready" &&
message.payload.sendOptions?.userMessageMetadata?.origin ===
BERDCTL_CROSS_SESSION_ORIGIN
);
}

export async function sendPromptToExistingSessionInBackground(
sessionId: string,
prompt: string,
Expand Down
Loading
Loading