Migrate to BetterPlayerPlus, refactor StoryView, and add RTL support - #221
Closed
MohammadAssaf10 wants to merge 20 commits into
Closed
Migrate to BetterPlayerPlus, refactor StoryView, and add RTL support#221MohammadAssaf10 wants to merge 20 commits into
MohammadAssaf10 wants to merge 20 commits into
Conversation
MohammadAssaf10
commented
Sep 20, 2025
MohammadAssaf10
commented
- Replace video player package by better player plus.
- Update dependencies and refactor story view implementation.
- Add RTL support to story.
- Update dependencies and refactor story view implementation. - Add RTL support to story.
…mproved gesture handling.
…izable button padding for improved layout control.
…ccess to optional properties and adding mounted check for event listener.
…wn, ensuring consistent behavior in story navigation.
…roving navigation consistency and simplifying state management.
…callback resumes playback correctly, improving user experience during navigation.
…, ensuring the current story is correctly managed and enhancing overall navigation flow.
This commit refactors the core `StoryView` widget and its related components for improved state management, performance, and clarity. Key changes include: * **Refactored `StoryView`:** Replaced the "shown" flag logic with a `currentIndex` for more predictable state management. * **Improved `StoryImage` and `StoryVideo`:** Enhanced lifecycle management, including better handling of load states, controller listeners, and resource disposal. * **Refactored `ImageLoader` and `VideoLoader`:** Implemented stream subscriptions for safer and more efficient resource loading and cancellation. * **Simplified `PageBar`:** Converted `PageBar` to a `StatelessWidget` and improved its rendering logic. * **Updated Dependencies:** Upgraded `better_player_plus` to `1.1.5` and other dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.