Repository navigation
Console tab - #798
Merged
Merged
Console tab#798
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds/enables the Console tab in the Qt client using the cflib2 (crazyflie-lib-python-v2) connection object, and adjusts the disconnect error dialog to avoid clashing with QtAsyncio.
Changes:
- Enable
ConsoleTabin the tabs registry so it loads in the UI. - Refactor
ConsoleTabto use cflib2 async APIs for console output and param writes. - Defer the disconnect “Communication failure” modal dialog via
QTimer.singleShot(0, ...)to avoid running it directly inside an async task.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/cfclient/ui/tabs/init.py | Enables ConsoleTab import and adds it to the available tabs list. |
| src/cfclient/ui/tabs/ConsoleTab.py | Reworks Console tab to use cflib2 Crazyflie + async console loop and async param set helpers. |
| src/cfclient/ui/main.py | Defers disconnect QMessageBox.critical via QTimer.singleShot to avoid event loop clashes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ArisMorgens
force-pushed
the
Aris/cflib2/Console_tab
branch
from
March 25, 2026 13:18
b6470f9 to
68ddfac
Compare
ArisMorgens
force-pushed
the
Aris/cflib2/Console_tab
branch
from
March 25, 2026 14:45
3865eb2 to
2b3eee7
Compare
gemenerik
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Console tab, running on crazyflie-lib-python-v2.
It also fixes a bug where the client crashed after the "too many packets lost" window is closed. The window was running its own event loop internally, which clashes with QtAsyncio.
QTimer.singleShotschedules it to open after the current task finishes.