Add aug 21 release - #93
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new bulk-search lookup strategy for the PubMed /publications endpoint and updates the benchmarking harness to compare current vs bulk-search, along with expanded unit/integration tests and refreshed documentation.
Changes:
- Implement
bulk-searchalternative-identifier resolution (singleterms_search+ safe reverse-mapping with fallback to exact per-ID_msearch). - Add Elasticsearch client helpers:
querymany_exact(...)(root-field term_msearch) andsearch_terms(...)(boundedterms_searchwith hit-total reporting). - Update benchmark CLI/tests/docs to replace the prior
two-phaseexperiment withbulk-search.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_publications_load.py | Updates benchmark harness tests to use bulk-search strategy and labels. |
| tests/test_elasticsearch.py | Adds coverage for querymany_exact request shape and search_terms behavior/result formatting. |
| tests/test_document_metadata.py | Reworks metadata service tests for bulk-search, adds fallback/ordering/concurrency cases, and expands live integration coverage across strategies. |
| README.md | Documents the new bulk-search experiment, updated index-shape expectations, and refreshed benchmark instructions. |
| biothings_annotator/webapp/openapi.json | Updates endpoint/schema descriptions to reflect alternate identifiers living in pubmed.identifiers. |
| biothings_annotator/application/views/document_metadata.py | Switches header-driven A/B selector from two-phase to bulk-search using strategy constants. |
| biothings_annotator/annotator/settings.py | Removes the deprecated DOCUMENT_METADATA_TWO_PHASE_LOOKUP setting. |
| biothings_annotator/annotator/elasticsearch.py | Introduces querymany_exact and search_terms plus shared exact-batch helper. |
| biothings_annotator/annotator/document_metadata.py | Implements bulk-search strategy, strategy selection, and safer reverse-mapping with fallback. |
| benchmarks/publications/workload.py | Updates supported lookup strategies to include bulk-search. |
| benchmarks/publications/runner.py | Renames paired observation arm and comparison logic from two-phase to bulk-search. |
| benchmarks/publications/report.py | Updates reporting keys/labels and delta semantics to bulk-search minus current. |
| benchmarks/publications/main.py | Updates CLI help text to reflect bulk-search paired comparisons. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add more benchmark testing for
Publicationsqueries