Fix test deployment - #91
Merged
Merged
Conversation
The test cluster sits behind an ingress that routes on the Host header, so "test" carries the header explicitly alongside its resolved host rather than leaving it to the URL. Verified against the forwarded service: the request returns 200 with the header and 404 without it. "test_local_forward" pairs the same header with localhost:9200, mirroring ci_local_forward, since the direct host is not reachable outside the cluster.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the annotator’s default Elasticsearch connection preset and deployment defaults to support a new “test” instance rollout while keeping backward compatibility with the prior ci naming.
Changes:
- Rename the default Elasticsearch connection preset from
citoin_cluster, while keepingcias an alias. - Add new Elasticsearch connection presets for the external test instance (
test,test_local_forward). - Update unit tests, Helm values, and README documentation to reflect the new defaults and presets.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
biothings_annotator/annotator/settings.py |
Switch default connection to in_cluster, add test/test_local_forward presets, keep ci as an alias. |
deploy/values.yaml |
Update Helm default elasticsearch_connection to in_cluster. |
README.md |
Document the new in_cluster default and the new test presets and intended usage. |
tests/test_elasticsearch.py |
Update expectations for new defaults, validate aliasing behavior, and add coverage for test presets. |
tests/test_document_metadata.py |
Add a unit test asserting DocumentMetadataService defaults to in_cluster when env is unset. |
tests/test_application_endpoints.py |
Update /version endpoint test to expect the default in_cluster connection when env is unset. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix deployment env to accommodate
testinstance rollout