Repository navigation
Replace float-asides with Sidenotes - #68
Merged
Merged
Conversation
janezd
changed the title
janezd
force-pushed
the
replace-float-aside-w-sidenote
branch
from
September 16, 2025 18:31
5614cef to
3f26001
Compare
This was referenced Sep 19, 2025
janezd
marked this pull request as ready for review
September 26, 2025 14:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces float-asides with Sidenote components rather than adding an element with CSS, as is done for other
<!!!marks. With this, float-asides (turned into Sidenotes) will rearrange to not overlap.This adds a rule for float-aside use: the content that is moved aside must end with a blank line. Previously, some float-asides were followed with a
<Question>or code block without any blank line.Must be merged after https://github.com/biolab/notes-books/pull/14, which fixes uses that are no longer permissible.
Merge if we decide such preprocessing is safe. Otherwise, we'd probably need to use Sidenotes instead float-asides.