Update translations - #2718
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fae1367. Configure here.
| "card_default_image_alt": "Bild in Kürze verfügbar", | ||
| "featured_promotions": { | ||
| "more_offers": "weitere Angebote" | ||
| "more_offers": "{count, plural, ein {weiteres Angebot} other {weitere Angebote}}" |
There was a problem hiding this comment.
Invalid ICU plural keywords
Medium Severity
Several locales use translated plural categories (ein, una, une, ét, ett) in more_offers instead of ICU keywords like one. Elsewhere in these files, plurals correctly use one/other. The singular branch never matches, so count 1 (two promotions) always falls through to other.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit fae1367. Configure here.
| "card_default_image_alt": "画像は近日公開予定", | ||
| "featured_promotions": { | ||
| "more_offers": "その他のオファー" | ||
| "more_offers": "{count, plural、オファーが他} other { 件}}" |
There was a problem hiding this comment.
Broken Japanese plural syntax
High Severity
The new more_offers value in ja.json is not valid ICU MessageFormat. It uses an ideographic comma, drops the plural categories, and has malformed braces, so formatting can fail or show a broken string instead of the previous working Japanese text.
Reviewed by Cursor Bugbot for commit fae1367. Configure here.
| "card_default_image_alt": "Image disponible bientôt", | ||
| "featured_promotions": { | ||
| "more_offers": "plus d'offres" | ||
| "more_offers": "{count, plural, une {more offer} other {more offers}}" |
There was a problem hiding this comment.
French string left in English
Medium Severity
more_offers in fr.json previously said plus d'offres, but the update uses English more offer / more offers. French storefronts will show English copy for this featured-promotions label.
Reviewed by Cursor Bugbot for commit fae1367. Configure here.
| "card_default_image_alt": "La imagen estará disponible próximamente", | ||
| "featured_promotions": { | ||
| "more_offers": "más ofertas" | ||
| "more_offers": "{count, plural, una {más posibilidades} other {más posibilidades}}" |
There was a problem hiding this comment.
Wrong Spanish offers translation
Medium Severity
Latin American Spanish locales changed más ofertas to más posibilidades, which means “more possibilities,” not “more offers.” es.json still uses oferta/ofertas, so these variants now show the wrong meaning in promotion callouts.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit fae1367. Configure here.
2 participants
This pull request was created automatically. Please check new translations, approve and deliver them.
Note
Low Risk
Locale JSON only; no application logic. Wrong or malformed ICU strings could show broken UI text for featured promotion callouts in affected languages.
Overview
Updates
products.featured_promotions.more_offersin 18 locale files from fixed phrases to ICU{count, plural, …}strings so the featured promotion “more offers” callout can vary with the number of additional promotions.Locales differ in wording (e.g. German weiteres Angebot vs weitere Angebote, Spanish oferta más vs más ofertas, Dutch Nog {count} …). Some entries still look worth a quick review: fr.json uses English “more offer/offers”, ja.json has a likely broken plural pattern, and several Spanish regional files use the same string for singular and plural (más posibilidades).
Reviewed by Cursor Bugbot for commit fae1367. Bugbot is set up for automated code reviews on this repo. Configure here.