feat(payment): PAYPAL-6634 Improve Error Messaging for Bank-Declined 3DS Authentication (PayPal PPCP) - #3378
Open
bc-pavlo-khodakivskyi wants to merge 1 commit into
Open
feat(payment): PAYPAL-6634 Improve Error Messaging for Bank-Declined 3DS Authentication (PayPal PPCP)#3378bc-pavlo-khodakivskyi wants to merge 1 commit into
bc-pavlo-khodakivskyi wants to merge 1 commit into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
1 issue from previous review remains unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 671fe69. Configure here.
bc-pavlo-khodakivskyi
force-pushed
the
PAYPAL-6634
branch
from
August 27, 2026 16:12
671fe69 to
b9d6cd0
Compare
bc-nick
approved these changes
Aug 28, 2026
bc-pavlo-khodakivskyi
force-pushed
the
PAYPAL-6634
branch
from
August 28, 2026 14:57
b9d6cd0 to
a65b0b2
Compare
…3DS Authentication (PayPal PPCP)
bc-pavlo-khodakivskyi
force-pushed
the
PAYPAL-6634
branch
from
August 30, 2026 21:08
a65b0b2 to
43b8397
Compare
Contributor
Author
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Improve Error Messaging for Bank-Declined 3DS Authentication (PayPal PPCP)
Rollout/Rollback
Revert
Testing
Screen.Recording.2026-08-27.at.13.03.24.mov
Screen.Recording.2026-08-27.at.13.00.51.mov
Note
Medium Risk
Changes payment failure handling and shopper-facing errors on the PayPal PPCP 3DS path; scope is limited to specific liability-shift outcomes but affects live checkout behavior.
Overview
Adds
PaymentMethodBankDeclinedAuthenticationError(type:bank_declined_authentication) so checkout can tell shoppers their bank declined 3DS and they should try another card, instead of a generic failure.For PayPal Commerce credit cards, when Card Fields
onApprovereportsliabilityShiftNOorUNKNOWN, the strategy throws that error. Because the PayPal SDK swallows errors fromonApproveand rejectssubmit()with its own error, the strategy sets a flag and re-throws the bank-declined error fromsubmitHostedForm; other submit failures still map toPaymentMethodFailedError(“Failed authentication…”). Unit tests coveronApprove, the SDK swallow/reject path, and the generic fallback.Reviewed by Cursor Bugbot for commit 43b8397. Bugbot is set up for automated code reviews on this repo. Configure here.