feat(payment): PAYPAL-6495 add BCP venmo wallet strategy - #3375
Open
bc-yaroslav-zhmutskyi wants to merge 1 commit into
Open
feat(payment): PAYPAL-6495 add BCP venmo wallet strategy#3375bc-yaroslav-zhmutskyi wants to merge 1 commit into
bc-yaroslav-zhmutskyi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Add BigCommerce Payments Venmo Wallet strategy
Rollout/Rollback
Revert
Testing
Currently have issue with venmo login, will add recording after it resolved
Note
Medium Risk
New payment wallet path touches order intent creation and tokenization proxying via PayPal SDK; pattern matches existing BCP wallet strategies but expands live Venmo cart checkout surface.
Overview
Adds a wallet button integration for BigCommerce Payments Venmo so merchants can show a Venmo wallet button on cart (or similar) surfaces, alongside the existing Venmo checkout button, customer, and payment strategies.
The new
BigCommercePaymentsVenmoWalletStrategyvalidatesmethodId,containerId, andbigcommerce_paymentsvenmooptions, decodesinitializationData, loads the PayPal SDK, and renders PayPal Buttons withFUNDING.VENMO. On click it creates a payment order intent for providerbigcommerce_payments.venmo, and on approve it proxies tokenization for methodbigcommerce_payments_venmo. Cart button styles from initialization data are normalized (including stripping gold color for Venmo), and the container is removed when the button is not eligible.Registration wires the factory through
PaypalCommerceWalletServicewith intent data keyBigcommercePaymentWalletIntentData, resolved for method idbigcommerce_paymentsvenmo, and exports are added in the package index. Unit tests cover validation, SDK load, button rendering, order intent, approve flow, ineligibility, and factory instantiation.Reviewed by Cursor Bugbot for commit ca9e0a3. Bugbot is set up for automated code reviews on this repo. Configure here.