Perf: Optimize font name matching with Set - #3374
Draft
TomA-R wants to merge 1 commit into
Draft
Conversation
Pre-cache font names from styles into a Set for O(1) lookup instead of repeatedly iterating through all styles for each link element. This reduces the nested loop complexity from O(n*m*k) to O(n*k + m) where: - n = number of link elements - m = number of style objects - k = average font names per family string Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves performance of font URL matching in hosted form.
Issue
The _getFontUrls() method was iterating through all style values for each link element,
resulting in O(nmk) complexity.
Changes
Performance Impact
Testing
Note
Low Risk
Small, local performance refactor of font URL filtering with no API or security changes.
Overview
Speeds up Google Fonts URL matching in hosted fields by collecting
fontFamilynames into aSetonce, then filtering stylesheet links against that cache instead of re-walking styles for every link.Behavior of
_getFontUrls()is unchanged: it still returnsfonts.googleapis.comstylesheet hrefs whose URLs contain a configured font name.Reviewed by Cursor Bugbot for commit 45b0315. Bugbot is set up for automated code reviews on this repo. Configure here.