-
Notifications
You must be signed in to change notification settings - Fork 215
feat(payment): PI-5431 [SPIKE] [FE] Surcharging (Bluesnap, Adyen) - PoC [do not merge] #3313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bc-ania
wants to merge
1
commit into
master
Choose a base branch
from
PI-5431
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import { createAction, ThunkAction } from '@bigcommerce/data-store'; | ||
| import { concat, defer, of } from 'rxjs'; | ||
| import { catchError } from 'rxjs/operators'; | ||
|
|
||
| import { InternalCheckoutSelectors } from '../checkout'; | ||
| import { throwErrorAction } from '../common/error'; | ||
| import { MissingDataError, MissingDataErrorType } from '../common/error/errors'; | ||
| import { RequestOptions } from '../common/http-request'; | ||
|
|
||
| import { FeeRequestBody } from './fee'; | ||
| import { FeeAction, FeeActionType } from './fee-actions'; | ||
| import FeeRequestSender from './fee-request-sender'; | ||
|
|
||
| // Mirrors StoreCreditActionCreator. The ApplyFeesSucceeded action carries the updated | ||
| // Checkout returned by the Fees API, which the checkout reducer merges into state | ||
| // (Checkout.fees + grandTotal + outstandingBalance) — same pattern as store credit / | ||
| // coupons, so the order summary re-renders with the surcharge. | ||
| export default class FeeActionCreator { | ||
| constructor(private _feeRequestSender: FeeRequestSender) {} | ||
|
|
||
| applyFees( | ||
| fees: FeeRequestBody[], | ||
| options?: RequestOptions, | ||
| ): ThunkAction<FeeAction, InternalCheckoutSelectors> { | ||
| return (store) => | ||
| concat( | ||
| of(createAction(FeeActionType.ApplyFeesRequested)), | ||
| defer(async () => { | ||
| const checkout = store.getState().checkout.getCheckout(); | ||
|
|
||
| if (!checkout) { | ||
| throw new MissingDataError(MissingDataErrorType.MissingCheckout); | ||
| } | ||
|
|
||
| // Send the checkout version for optimistic concurrency (like store credit), | ||
| // so an in-flight surcharge doesn't clash with a concurrent checkout update. | ||
| const version = options?.version ?? checkout.version; | ||
|
|
||
| const { body } = await this._feeRequestSender.applyFees(checkout.id, fees, { | ||
| ...options, | ||
| version, | ||
| }); | ||
|
|
||
| return createAction(FeeActionType.ApplyFeesSucceeded, body); | ||
| }), | ||
| ).pipe(catchError((error) => throwErrorAction(FeeActionType.ApplyFeesFailed, error))); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { Action } from '@bigcommerce/data-store'; | ||
|
|
||
| import { Checkout } from '../checkout'; | ||
| import { RequestError } from '../common/error/errors'; | ||
|
|
||
| export enum FeeActionType { | ||
| ApplyFeesRequested = 'APPLY_FEES_REQUESTED', | ||
| ApplyFeesSucceeded = 'APPLY_FEES_SUCCEEDED', | ||
| ApplyFeesFailed = 'APPLY_FEES_FAILED', | ||
| } | ||
|
|
||
| export type FeeAction = ApplyFeesRequestedAction | ApplyFeesSucceededAction | ApplyFeesFailedAction; | ||
|
|
||
| export interface ApplyFeesRequestedAction extends Action { | ||
| type: FeeActionType.ApplyFeesRequested; | ||
| } | ||
|
|
||
| export interface ApplyFeesSucceededAction extends Action<Checkout> { | ||
| type: FeeActionType.ApplyFeesSucceeded; | ||
| } | ||
|
|
||
| export interface ApplyFeesFailedAction extends Action<RequestError> { | ||
| type: FeeActionType.ApplyFeesFailed; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale Adyen BIN on re-entry
Medium Severity
this._binis only updated inonBinValueand is not cleared when the card becomes invalid or the PAN changes. A later validonChangecan reuse the previous BIN for deduplication and surcharge payloads before Adyen emits a new BIN.Additional Locations (1)
packages/adyen-integration/src/adyenv3/adyenv3-payment-strategy.ts#L482-L485Reviewed by Cursor Bugbot for commit c2285b3. Configure here.