-
Notifications
You must be signed in to change notification settings - Fork 215
feat(payment): PAYPAL-6645 Tech PoC [FE]: Pay by Invoice checkout — frontend implementation approach #3292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
serhiiFilkovskyi
wants to merge
1
commit into
master
Choose a base branch
from
PAYPAL-6645
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(payment): PAYPAL-6645 Tech PoC [FE]: Pay by Invoice checkout — frontend implementation approach #3292
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
32 changes: 32 additions & 0 deletions
32
...bigcommerce-payments-invoices/bigcommerce-payments-invoices-payment-initialize-options.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { | ||
| PayPalButtonStyleOptions, | ||
| PayPalBuyNowInitializeOptions, | ||
| } from '../bigcommerce-payments-types'; | ||
|
|
||
| export default interface BigCommercePaymentsInvoicesPaymentInitializeOptions { | ||
| /** | ||
| * A set of styling options for the checkout button. | ||
| */ | ||
| style?: PayPalButtonStyleOptions; | ||
|
|
||
| /** | ||
| * The option that used to initialize a PayPal script with provided currency code. | ||
| */ | ||
| currencyCode?: string; | ||
|
|
||
| /** | ||
| * The options that required to initialize Buy Now functionality. | ||
| */ | ||
| buyNowInitializeOptions?: PayPalBuyNowInitializeOptions; | ||
|
|
||
| /** | ||
| * | ||
| * A callback that gets called when PayPal SDK restricts to render PayPal component. | ||
| * | ||
| */ | ||
| onEligibilityFailure?(): void; | ||
| } | ||
|
|
||
| export interface WithBigCommercePaymentsInvoicesPaymentInitializeOptions { | ||
| bigcommerce_payments_invoices?: BigCommercePaymentsInvoicesPaymentInitializeOptions; | ||
| } | ||
59 changes: 59 additions & 0 deletions
59
...ation/src/bigcommerce-payments-invoices/bigcommerce-payments-invoices-payment-strategy.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| import { | ||
| InvalidArgumentError, | ||
| OrderFinalizationNotRequiredError, | ||
| OrderRequestBody, | ||
| Payment, | ||
| PaymentArgumentInvalidError, | ||
| PaymentInitializeOptions, | ||
| PaymentIntegrationService, | ||
| PaymentRequestOptions, | ||
| PaymentStrategy, | ||
| } from '@bigcommerce/checkout-sdk/payment-integration-api'; | ||
|
|
||
| import { WithBigCommercePaymentsInvoicesPaymentInitializeOptions } from './bigcommerce-payments-invoices-payment-initialize-options'; | ||
|
|
||
| export default class BigCommercePaymentsInvoicesPaymentStrategy implements PaymentStrategy { | ||
| constructor(private paymentIntegrationService: PaymentIntegrationService) {} | ||
|
|
||
| async initialize( | ||
| options?: PaymentInitializeOptions & | ||
|
serhiiFilkovskyi marked this conversation as resolved.
|
||
| WithBigCommercePaymentsInvoicesPaymentInitializeOptions, | ||
| ): Promise<void> { | ||
| const { methodId } = options || {}; | ||
|
|
||
| if (!methodId) { | ||
| throw new InvalidArgumentError( | ||
| 'Unable to initialize payment because "options.methodId" argument is not provided.', | ||
| ); | ||
| } | ||
|
|
||
| await this.paymentIntegrationService.loadPaymentMethods(); | ||
| } | ||
|
|
||
| async execute(payload: OrderRequestBody, options?: PaymentRequestOptions): Promise<void> { | ||
| const { payment, ...order } = payload; | ||
| const { methodId } = payment || {}; | ||
|
|
||
| if (!payment || !methodId) { | ||
| throw new PaymentArgumentInvalidError(['payment']); | ||
| } | ||
|
|
||
| const submitPaymentPayload: Payment = { | ||
| methodId, | ||
| paymentData: { | ||
| formattedPayload: {}, | ||
| }, | ||
| }; | ||
|
|
||
| await this.paymentIntegrationService.submitOrder(order, options); | ||
| await this.paymentIntegrationService.submitPayment(submitPaymentPayload); | ||
| } | ||
|
|
||
| finalize(): Promise<void> { | ||
| return Promise.reject(new OrderFinalizationNotRequiredError()); | ||
| } | ||
|
|
||
| deinitialize(): Promise<void> { | ||
| return Promise.resolve(); | ||
| } | ||
| } | ||
15 changes: 15 additions & 0 deletions
15
...rc/bigcommerce-payments-invoices/create-bigcommerce-payments-invoices-payment-strategy.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import { | ||
| PaymentStrategyFactory, | ||
| toResolvableModule, | ||
| } from '@bigcommerce/checkout-sdk/payment-integration-api'; | ||
|
|
||
| import BigCommercePaymentsInvoicesPaymentStrategy from './bigcommerce-payments-invoices-payment-strategy'; | ||
|
|
||
| const createBigCommercePaymentsInvoicesPaymentStrategy: PaymentStrategyFactory< | ||
| BigCommercePaymentsInvoicesPaymentStrategy | ||
| > = (paymentIntegrationService) => | ||
| new BigCommercePaymentsInvoicesPaymentStrategy(paymentIntegrationService); | ||
|
|
||
| export default toResolvableModule(createBigCommercePaymentsInvoicesPaymentStrategy, [ | ||
| { id: 'bigcommerce_payments_invoices' }, | ||
| ]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -172,6 +172,15 @@ export default class PaymentRequestTransformer { | |
| return { ...paymentMethod, id: CheckoutButtonMethodType.BRAINTREE_PAYPAL }; | ||
| } | ||
|
|
||
| // BigCommerce Payments Invoices: the method is registered as | ||
| // `bigcommerce_payments_invoices`, but BigPay expects the provider gateway | ||
| // `bigcommerce_payments` with `method: 'invoice'`. The BigPay client's id mapper | ||
| // doesn't recognise this method, so it would otherwise fall through and send the | ||
| // raw method id as the gateway. Remap the id to the provider here. | ||
| if (paymentMethod.id === 'bigcommerce_payments_invoices') { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove after bigcommerce/bigpay-client-js#473 will be merged |
||
| return { ...paymentMethod, id: 'bigcommerce_payments' }; | ||
| } | ||
|
|
||
| return paymentMethod; | ||
| } | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.