Conversation
Author
|
Sorry, I dont know why the CI fails, I know nothing about typescript, I just needed the dump of all commands in a human readable format, which was successful. TYVM @Jazcash <3 |
p2004a
force-pushed
the
master
branch
2 times, most recently
from
February 1, 2026 16:06
9a65e09 to
f0ea099
Compare
p2004a
requested changes
Feb 1, 2026
| const { startPositions, factions, colors } = await this.parsePackets(this.bufferStream.read(this.header.demoStreamSize)); | ||
| const { startPositions, factions, colors, packets} = await this.parsePackets(this.bufferStream.read(this.header.demoStreamSize)); | ||
|
|
||
| this.packets = packets; |
Collaborator
There was a problem hiding this comment.
We definitely do not want to aggregate unconditionally all packets in memory. The aggregation must be done on the client side.
|
|
||
| `npm run build` | ||
|
|
||
| `npx ts-node parse-demo.ts mydemo.sdfz > mydemo.json` |
Collaborator
There was a problem hiding this comment.
Instead, the script should be added to https://docs.npmjs.com/cli/v11/configuring-npm/package-json#bin and then people can use npx to run the parser without forking/installing etc
Collaborator
|
CLI was released https://github.com/beyond-all-reason/demo-parser#cli |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.