-
Notifications
You must be signed in to change notification settings - Fork 90
Handle Battle, Lobby, Party, and Matchmaking status reconnections #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 31 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
bd18fab
Signals for user/self to pass received data
Hectate 713e673
Party state recovery
Hectate 9718d08
lobby and matchmaking recovery
Hectate 8833b28
Mild cleanups
Hectate 125bcc4
battle start tweaks
Hectate 48209e7
Wired up rejoin battle confirmation
Hectate dfd85d2
Watch for battle ending on user's updated event
Hectate f6f206d
Added in-battle UI indicator and navigation
Hectate bb1b838
Push user to matchmaking view
Hectate 103833d
Some cleanups
Hectate 7e30a44
Tweaks
Hectate 2298db9
Fixed tests
Hectate b7df4fe
user.currentBattle is correct now
Hectate 3249891
ported an old fix that was never applied
Hectate bf7caab
Fix party update
Hectate 22f869f
Translation strings added
Hectate e251920
null/undefined state handling
Hectate 828b6ce
Tweaks for null/undefined objects
Hectate 5d9e156
format script run
Hectate aac9dad
Merge remote-tracking branch 'upstream/master' into reconnect-stores
Hectate 1a43acf
Added mock router functions
Hectate 2d261f2
Merge remote-tracking branch 'upstream/master' into reconnect-stores
Hectate a9302a6
More mocks for new tests
Hectate c5cc107
fixed micro-milliseconds conversion
Hectate 81de6ae
Handled clearing battle states in more places
Hectate 3bf4b94
Reminder for later
Hectate bdceffa
Tests to cover missing server implementation
Hectate a233f52
Fixes from review
Hectate 2370875
more review tweaks
Hectate d149931
Store init guards per review
Hectate 1ed7289
Lobby chat history preservation
Hectate f0dce7f
Implement requestStructured
Hectate 0a1d607
removed comment
Hectate 1ac480e
Swapped signals for in-store listeners
Hectate 3733af3
Refactored chats to use maps for all types
Hectate 3f08558
requestJoinLobby explicit parameter names
Hectate 0dfa43f
Tachyon version bumped to 1.24.0
Hectate 2f3fc49
Explicit "not_in_lobby" error handling
Hectate ee46603
Added "rejoin" text to animation
Hectate da45da2
Updated tachyon references
Hectate a84cad0
Cleaner matchmaking update, tests
Hectate 9316e82
Temporary backwards compat
Hectate c55c6ec
updated IP checks
Hectate b03664c
More back compat fixes
Hectate ddf6cbf
Merge remote-tracking branch 'upstream/master' into reconnect-stores
Hectate 1e399cd
log.info > log.debug
Hectate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| SPDX-FileCopyrightText: 2026 The BAR Lobby Authors | ||
|
|
||
| SPDX-License-Identifier: CC0-1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| <!-- | ||
| SPDX-FileCopyrightText: 2026 The BAR Lobby Authors | ||
|
|
||
| SPDX-License-Identifier: MIT | ||
| --> | ||
|
|
||
| <template> | ||
| <Modal v-model="isOpen" :title="t('lobby.components.battle.rejoinBattleModal.title')"> | ||
| <div class="container"> | ||
| <p>{{ t("lobby.components.battle.rejoinBattleModal.description1") }}</p> | ||
| <p>{{ t("lobby.components.battle.rejoinBattleModal.description2") }}</p> | ||
| <div class="flex-row flex-center padding-top-lg gap-xl"> | ||
| <Button class="green fullwidth" @click="onConfirm">{{ | ||
| t("lobby.components.battle.rejoinBattleModal.rejoinButton") | ||
| }}</Button> | ||
| <Button class="red fullwidth" @click="onCancel">{{ t("lobby.components.battle.rejoinBattleModal.ignoreButton") }}</Button> | ||
| </div> | ||
| </div> | ||
| </Modal> | ||
| </template> | ||
|
|
||
| <script lang="ts" setup> | ||
| import { computed } from "vue"; | ||
| import Modal from "@renderer/components/common/Modal.vue"; | ||
| import Button from "@renderer/components/controls/Button.vue"; | ||
| import { tachyon, tachyonStore } from "@renderer/store/tachyon.store"; | ||
| import { useTypedI18n } from "@renderer/i18n"; | ||
|
|
||
| const { t } = useTypedI18n(); | ||
|
|
||
| const props = withDefaults( | ||
| defineProps<{ | ||
| modelValue?: boolean; | ||
| }>(), | ||
| { modelValue: false } | ||
| ); | ||
|
|
||
| const emit = defineEmits<{ (e: "update:modelValue", v: boolean): void }>(); | ||
| const isOpen = computed({ | ||
| get: () => props.modelValue, | ||
| set: (v: boolean) => emit("update:modelValue", v), | ||
| }); | ||
|
|
||
| function onConfirm() { | ||
|
Hectate marked this conversation as resolved.
|
||
| console.log("Rejoining battle..."); | ||
| if (tachyonStore.springConnectionDetails) { | ||
| tachyon.launchMultiplayerBattle(tachyonStore.springConnectionDetails); | ||
| } | ||
| isOpen.value = false; | ||
| } | ||
| function onCancel() { | ||
| console.log("Ignoring rejoin battle prompt."); | ||
| isOpen.value = false; | ||
| } | ||
| </script> | ||
|
|
||
| <style lang="scss" scoped></style> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| <!-- | ||
| SPDX-FileCopyrightText: 2026 The BAR Lobby Authors | ||
|
|
||
| SPDX-License-Identifier: MIT | ||
| --> | ||
|
|
||
| <template> | ||
| <video :src="video" autoplay muted loop></video> | ||
| </template> | ||
|
|
||
| <script lang="ts" setup> | ||
| import { miscVideos } from "@renderer/assets/assetFiles"; | ||
|
|
||
| const video = miscVideos["./videos/misc/active_battle.mkv"]; | ||
| </script> | ||
|
|
||
| <style lang="scss" scoped> | ||
| video { | ||
| max-width: 100%; | ||
| max-height: 200px; | ||
| height: auto; | ||
| object-fit: fill; | ||
| } | ||
| </style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.