-
-
Notifications
You must be signed in to change notification settings - Fork 22
Future-proof Chart against changing Toga Widget initialization #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
freakboy3742
merged 11 commits into
beeware:main
from
HalfWhitt:future-proof-for-toga-widget-init
Apr 22, 2025
Merged
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
eb222ed
Added compatibility for Toga widget initialization change
HalfWhitt 1a1edc1
Added changenote
HalfWhitt 9fa32ed
Oops, forgot to install pre-commit for this repo
HalfWhitt 911e9e1
Switched to version requirement
HalfWhitt c58378c
Merge branch 'main' into future-proof-for-toga-widget-init
HalfWhitt f36adeb
Removed extraneous version from keywords
HalfWhitt fc0390c
Reworded change note
HalfWhitt 78339d4
Update padding to margin
HalfWhitt bfc8102
Clean up package dependencies.
freakboy3742 781f14e
Adjust matplotlib API usage.
freakboy3742 e198ad8
Merge branch 'main' into future-proof-for-toga-widget-init
freakboy3742 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| The initialization of Chart has been updated to be compatible with Toga 0.5.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,6 +47,7 @@ dev = [ | |
| "setuptools_scm == 8.2.0", | ||
| "tox == 4.24.2", | ||
| "toga-dummy >= 0.4.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can remove |
||
| "toga-dummy >= 0.5.0, < 0.6.0", | ||
| ] | ||
| # Docs are always built on a specific Python version; see RTD and tox config files. | ||
| docs = [ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that toga 0.5.0 is out, is there a reason to remove the range you had before?
"toga >= 0.5.0, < 0.6.0",