Move six entries out of 3.3.0, where they never shipped - #2154
Merged
Conversation
The entries for #2139 through #2145 sit under `## 3.3.0`, but none of those commits is an ancestor of the v3.3.0 tag - they landed two days after the release and were filed at the top of what was then the topmost section. Left alone they would stay attributed to a release that never contained them, and 3.4.0's notes would omit six user-visible changes, among them the fix for #1686. Moved verbatim into the unreleased section, keeping the subsection their author chose rather than re-categorizing on the way past. Also closes a gap inside 3.3.0's own list, where a blank line between two entries made the rest of them a separate loose list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turned this up while checking the CHANGELOG was ready for a release.
The entries for #2139 through #2145 are filed under
## 3.3.0, but none of those commits is an ancestor of thev3.3.0tag - they merged two days after the release and went to the top of what was then the topmost section. Left as-is they'd stay attributed to a release that never contained them, and 3.4.0's notes would silently omit six user-visible changes, including the fix for #1686.Moved verbatim into the unreleased section, keeping the subsection their author chose rather than re-categorizing them on the way past.
Also closes a gap inside 3.3.0's own list: a blank line between two entries was splitting the rest into a separate loose list.
Everything else merged since v3.3.0 is accounted for. The five PRs with no entry are deliberate - screenshots (#2129), an internal measurement (#2143), and docs or fixes for code that hasn't been in a release yet (#2149, #2150, #2153).