Skip to content

Fix unsafe curl-pipe-bash pattern in PHP install scripts #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
semgrep-code-badoo wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix unsafe curl-pipe-bash pattern in PHP install scripts #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,9 @@ build_php_c() {
build_php7.0_mac() {
internal_build_cpp
# Install PHP
curl -s https://php-osx.liip.ch/install.sh | bash -s 7.0
curl -s https://php-osx.liip.ch/install.sh -o /tmp/php-install.sh
bash /tmp/php-install.sh 7.0
rm -f /tmp/php-install.sh
PHP_FOLDER=`find /usr/local -type d -name "php5-7.0*"` # The folder name may change upon time
test ! -z "$PHP_FOLDER"
export PATH="$PHP_FOLDER/bin:$PATH"
Expand All @@ -508,7 +510,9 @@ build_php7.3_mac() {
# Install PHP
# We can't test PHP 7.4 with these binaries yet:
# https://github.com/liip/php-osx/issues/276
curl -s https://php-osx.liip.ch/install.sh | bash -s 7.3
curl -s https://php-osx.liip.ch/install.sh -o /tmp/php-install.sh
bash /tmp/php-install.sh 7.3
rm -f /tmp/php-install.sh
PHP_FOLDER=`find /usr/local -type d -name "php5-7.3*"` # The folder name may change upon time
test ! -z "$PHP_FOLDER"
export PATH="$PHP_FOLDER/bin:$PATH"
Expand Down