test(pino): reproduce onError worker clone failure - #487
Open
islameldigwi wants to merge 2 commits into
Open
Conversation
islameldigwi
marked this pull request as ready for review
July 31, 2026 11:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
onErrorcallback.@axiomhq/pinoso the public worker transport path can be exercised.Why
Pino serializes worker transport options before loading the transport. Function-valued options are not structured-cloneable, so supplying the supported
onErrorcallback currently throws aDataCloneErrorbefore the Axiom transport starts.This draft captures the behavior in a minimal test so a follow-up implementation can make the worker path safe without losing error handling.
Impact
There is no production behavior change in this PR. The new regression test intentionally fails until the transport handles the callback across the worker boundary.
Validation
pnpm --filter @axiomhq/pino typecheck— passespnpm --filter @axiomhq/pino exec vitest run test/unit/worker-transport.spec.ts— intentionally fails withDataCloneError: () => void 0 could not be cloned.