-
Notifications
You must be signed in to change notification settings - Fork 3
fix(ai): replace static async_hooks require in eval context #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gilfoyle-sre
wants to merge
11
commits into
main
Choose a base branch
from
fix/static-async-hooks-import
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e9b4bee
fix(ai): replace dynamic async_hooks require
gilfoyle-sre 2168a23
chore: checkpoint before runtime budget exit (ses-1772758210957-80ac5…
gilfoyle-sre 6b1b942
test(context): harden async_hooks fallback coverage
gilfoyle-sre dbf16db
fix(ai): prevent fallback context leakage
gilfoyle-sre be9ad71
Harden fallback async context restoration
gilfoyle-sre 2e268e3
chore: checkpoint before runtime budget exit (ses-1772758210957-80ac5…
gilfoyle-sre f49f28f
fix: prevent fallback context leak on detached async runs
gilfoyle-sre 10fd0c4
fix(ai): allow safe sync nesting in fallback context
gilfoyle-sre 4bcce87
chore: checkpoint before runtime budget exit (ses-1772758210957-80ac5…
gilfoyle-sre 8332e8a
fix: allow sync nesting in fallback context manager
gilfoyle-sre d4ed30c
style: fix formatting in eval context manager
gilfoyle-sre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AsyncLocalStorage unavailable on Node 20 ESM after removing createRequire
Medium Severity
On Node.js 20 running ESM,
process.getBuiltinModuleis not available (added in v22.3.0, not backported to Node 20 LTS). In ESM mode,globalThis.requireandprocess.mainModule.requireare also unavailable.globalThis.AsyncLocalStorageis not a global in Node.js. All four strategies ingetAsyncLocalStorageConstructorfail, silently falling back to the in-memory manager. The old code usedcreateRequirefromnode:modulewhich worked in ESM on all Node versions. Since the context manager is reachable from the main SDK entry points (viastorage.ts→app-scope.ts/context.ts), this affects all users on Node 20 ESM, not just eval users — context propagation acrossawaitboundaries will silently break.Additional Locations (1)
packages/ai/src/evals/context/manager.ts#L75-L90