TypedIdentifier - #6
Open
maciejhirsz wants to merge 2 commits into
Open
Conversation
Y-Nak
pushed a commit
to fe-lang/yultsur
that referenced
this pull request
Nov 27, 2024
Fix function parser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First batch of changes from the big PR:
TypedIdentifier, following the grammar spec, that must have a type. Function definitions and variable declarations now useVec<TypedIdentifier>instead ofVec<Identifier>.Fromimpls to easily create instances ofIdentifierfrom string literals ("foo".into()orIdentifier::from("foo")).Validatorimpl forIdentifierchecks that the identifier is in accordance with the grammar.Stringto&'staticstr in the validator, although customenumor using theerror_chaincrate would be better here I reckon.