Fix fetching binary secrets - #183
Open
dancorne wants to merge 1 commit into
Open
Conversation
The SDK handles decoding from base64 so this code was failing for any binary secrets because it was receiving the decoded string already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd originally opened #131 as a bugfix PR, but then deleted my fork which closed the PR without me realising 😅
The SDK already decodes from base64 automatically so this was attempting to decode again, which fails with the below error:
It looks like the SAM template uses only string secrets so I'm not sure many people would've hit this branch of logic, but we added one of the secrets as binary and SSOSync stopped working.
Resolves #130
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.