Conversation
Author
|
@PettitWesley @mforutan this adds optional
Happy to change the values shape if you'd rather this reuse |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #1307
Description of changes
Optional
luaScriptsvalues, ConfigMap, DaemonSet mount at/fluent-bit/scripts/. Empty default is a no-op. Rolling update via checksum annotation when scripts are set.Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
Repo
make verify(scripts/validate-charts.sh,validate-chart-versions.sh,lint-charts.sh) — pass.aws-for-fluent-bitversion 0.2.0 → 0.2.1.make packageproducedaws-for-fluent-bit-0.2.1.tgz.helm lint stable/aws-for-fluent-bit— pass (default and with a luaScripts override).helm template test-fb stable/aws-for-fluent-bit --namespace kube-system(defaultluaScripts: {}) — no luascripts ConfigMap, no/fluent-bit/scripts/volume or volumeMount, nochecksum/luascripts.helm templatewith a multilinehelpers.luaoverride — ConfigMap YAML parses; script body is indata.helpers.lua; DaemonSet has the luascripts volume, mount at/fluent-bit/scripts/, andchecksum/luascripts.kubeconform -strict -ignore-missing-schemasandkubeval --strict --ignore-missing-schemason default and lua override renders — pass.Did not apply to a cluster (no EKS/kind install, no log-shipping e2e).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.