Fix Automake missing .Plo dependency error in efa-dp-direct fixes #1353 - #1356
Open
ryanhankins wants to merge 1 commit into
Open
Fix Automake missing .Plo dependency error in efa-dp-direct fixes #1353#1356ryanhankins wants to merge 1 commit into
ryanhankins wants to merge 1 commit into
Conversation
Contributor
|
bot:aws:retest |
Use a relative path (../) instead of the $(top_srcdir) variable for libefa_cuda_dp_la_SOURCES in src/Makefile.am. When HAVE_GDAKI evaluates to false, Automake correctly skips building the libefa_cuda_dp.la library. However, due to a known Automake bug involving subdir-objects combined with $(top_srcdir), config.status fails to generate the dummy empty .deps/*.Plo dependency files for the skipped sources. Because the generated Makefile still unconditionally includes these .Plo files, the missing file causes `make` to fail with a "No rule to make target '.../libefa_cuda_dp_la-efa_cuda_dp.Plo'" error. Switching to a relative path bypasses this Automake bug, allowing config.status to calculate paths properly and generate the dummy dependency files, resolving the build error without breaking out-of-tree (VPATH) builds. Signed-off-by: Ryan Hankins <ryan.hankins@hpe.com>
avivbenchorin
force-pushed
the
fix_aws_ofi_nccl_efa_build
branch
from
August 14, 2026 23:00
26c9540 to
45edd15
Compare
Contributor
Author
|
Thank you for looking at this. This will block 1.21.0 for us (in case that wasn't obvious). |
Contributor
Why? The release tarballs should all be built with AM 1.16.5, which won't have the bug. We weren't intending to pull this into the 1.21.0 release, but perhaps we missed an impact issue. |
Collaborator
|
bot:aws:retest |
Contributor
Author
|
We are currently building off the --branch from a git clone. It probably would be wise to build from the released tarball instead. I'll check and see if that works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a relative path instead of the $(top_srcdir) variable for libefa_cuda_dp_la_SOURCES in src/Makefile.am.
When HAVE_GDAKI evaluates to false, Automake correctly skips building the libefa_cuda_dp.la library. However, due to a known Automake bug involving subdir-objects combined with $(top_srcdir), config.status fails to generate the dummy empty .deps/*.Plo dependency files for the skipped sources.
Because the generated Makefile still unconditionally includes these .Plo files, the missing file causes
maketo fail with a "No rule to make target 'libefa_cuda_dp_la-efa_cuda_dp.Plo'" error. Switching to a relative path bypasses this Automake bug, allowing config.status to calculate paths properly and generate the dummy dependency files, resolving the build error without breaking out-of-tree (VPATH) builds.Issue #, if available:
#1353
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.