Skip to content

gdrcopy: fall back to the v1 pin API when the v2 pin ioctl is unsupported (gdrdrv < 2.5) #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmvevents wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

gdrcopy: fall back to the v1 pin API when the v2 pin ioctl is unsupported (gdrdrv < 2.5) #1354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/nccl_ofi_gdrcopy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,15 @@ int nccl_ofi_gdrcopy_ctx::register_region(void *device_ptr, size_t size, RegHand
ret = pimpl->gdr_pin_buffer_v2_fn(pimpl->gdr, regbgn,
handle->gdr_reglen, flags, &mh);
}
/* On a host whose gdrdrv kernel module predates 2.5 while
* userspace libgdrapi is 2.5+, the v2 pin ioctl is not
* recognized by the kernel (EINVAL/ENOTTY) even though the
* runtime resolved gdr_pin_buffer_v2. Fall back to the v1 pin
* API, which is identical at the gdr_mh_t output level. */
if (ret == EINVAL || ret == ENOTTY) {
ret = pimpl->gdr_pin_buffer_fn(pimpl->gdr, regbgn,
handle->gdr_reglen, 0, 0, &mh);
}
} else {
ret = pimpl->gdr_pin_buffer_fn(pimpl->gdr, regbgn, handle->gdr_reglen, 0, 0, &mh);
}
Expand Down