feat(eval): online-insight update (P2) - #2069
Open
jariy17 wants to merge 2 commits into
Open
Conversation
Adds `eval online-insight update` + updateOnlineInsight client method: merges over the current config, sets insights/clusteringConfig (never evaluators), repoints the data source, and keeps the execution role caller-supplied (no re-scope machinery — insight configs are BYO-only).
github-actions
Bot
added
agentcore-harness-reviewing
jariy17
marked this pull request as ready for review
August 22, 2026 15:56
jariy17
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command
What
eval online-insight updatehandler +updateOnlineInsightclient method.insights/clusteringConfig(never evaluators), repoints the data source (agent | data-source | endpoint/clear-endpoint), and passes the caller--role-arnstraight through.--update-role, no role-scope warning) — insight configs are BYO-role only.Stack
P1 #2067 → P2 (this) → P3 online-eval BYO role → P4 TUI get/list (+ #2029). See the plan artifact.
Verification
tsc clean; golden test hierarchy updated to include
update(19/19 replay). Update golden fixture + real-deploy bug bash: in progress.