Skip to content

chore: bump openjd-sessions to 0.11.0 #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seant-aws merged 1 commit into from
Aug 20, 2026
Merged

chore: bump openjd-sessions to 0.11.0 #1068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ dependencies = [
"boto3 >= 1.34.75",
"deadline-job-attachments == 0.1.3",
# Pinned to patch version due to Host Config Script runner usage of private OpenJD Sessions API.
"openjd-sessions == 0.10.14",
"openjd-sessions == 0.11.0",

@github-actions github-actions Bot Aug 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openjd-sessions 0.11.0 ships a documented breaking change: the session working directory name is no longer prefixed with the session id (_create_working_directory now passes prefix="" to TempDir, so the name is just mkdtemp()'s 8 random chars).

The existing e2e test test/e2e/test_worker_config.py::test_session_root_dir asserts exactly that prefix and will fail against 0.11.0:

  • Linux (line 231): if [[ "$cwd" != {session_root_dir}/session-* ]]
  • Windows (line 249): if (-not ($cwd -like '{session_root_dir}\\session-*'))

With 0.11.0 the cwd is <session_root_dir>/<8 random chars>, so both branches take the FAIL path and the job exits 1.

Suggest updating that test in this PR to assert only that the cwd is under session_root_dir (drop the session- prefix expectation), otherwise the e2e suite breaks on this bump.

@github-actions github-actions Bot Aug 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-on to the same 0.11.0 breaking change: docs/state.md still documents the old session-directory naming and is now wrong.

docs/state.md:188-193 says:

Session directories are created as children of the session root directory. The directories begin with the session ID, with trailing random characters:

<SESSION_ROOT_DIR>/<SESSION_ID>_a159c9

As of 0.11.0 the name is mkdtemp()'s 8 random characters with no session-id prefix, so the documented layout no longer matches reality. This matters operationally, not just cosmetically: the section immediately below (lines 203-209) documents --retain-session-dir / DEADLINE_WORKER_RETAIN_SESSION_DIR, and the whole point of retained directories is post-hoc inspection. With this bump, an operator can no longer map a retained directory back to a session by its name — upstream's own note says the mapping now has to come from the session log at <worker_logs_dir>/<queue_id>/<session_id>.log.

Worth updating this section in the same PR, and pointing operators at the session log as the way to attribute a retained directory.

"openjd-model >= 0.11.4, < 0.12",
# tomli became tomllib in standard library in Python 3.11
"tomli == 2.0.* ; python_version<'3.11'",
Expand Down
Loading