Repository navigation
Conversation
- A pending play() no longer shows the old video after a source switch.
hide() and a newer play() make an older request obsolete. Before, the
late promise showed video A again and emitted playing, while video B
waited to load.
- Hydration detection only checks this.$.vnode.el. The isConnected check
treated a server-rendered container outside the document as a
client-only mount and caused a hydration mismatch.
- The types pass the props as runtime options to DefineComponent. With
Vue 3.2, a plain props interface lost the required flag, so a missing
src compiled without an error.
- The media type lookup only reads own properties. Before, a URL ending
in ".constructor" got the type "function Object() { [native code] }".
- The test for the sources order uses its own unsorted array. Before, an
earlier test sorted the shared fixture, so the test passed even with
the old in-place sort.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- eslint 8 -> 9, eslint-config-avidofood 3 -> 4 (flat config). The config brings eslint-plugin-vue 10 and eslint-plugin-import, so they are no longer direct dev dependencies. - eslint.config.mjs replaces .eslintrc.js. The lint script is "eslint ." and ignores dist/ and demo/public/. - eslint-plugin-vue 10 uses postcss-selector-parser 7.1.6. This fixes the last Dependabot alert (GHSA-rj75-hqrm-r3gf, dev only). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A patch release: bug fixes from the Codex Astra review of 2.5.0 and the ESLint 9 tooling, see CHANGELOG.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Codex Astra re-review found that the source-switch fix was not complete. When pause() or stop() came while play() was pending, the promise still showed the video and emitted playing afterwards, although the video was paused. pause() now cancels the pending request, and stop() uses pause(). cancelPlayRequest() holds the shared logic of hide(), pause() and play(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release 2.5.1. Merge with a merge commit.
An independent review by Codex (gpt-6-astra) of 2.5.0 found five minor problems. Two re-reviews of this branch found one more and confirmed all fixes ("ok to publish 2.5.1").
Fixes
play()no longer shows the previous video after a source switch.hide(),pause(),stop()and a newerplay()cancel a pending request.this.$.vnode.el.src. The types pass the props as runtime options toDefineComponent..constructor,.__proto__).sourcesorder uses its own unsorted array, so it catches an in-place sort.Tooling
eslint.config.mjsreplaces.eslintrc.js). This fixes the last Dependabot alert (#87, dev only). The published files do not change because of this.Testing
npm run lint,npm test(62 tests and the type check),npm run buildandnpm pack --dry-runpass in fresh clones on Node 22.12 and 24.vue-tscpasses.@arethetypeswrong/clireports no problems.🤖 Generated with Claude Code