Skip to content

bridge: instrument calculateMaxForBridge - #226

Merged
Makyl merged 1 commit into
mainfrom
bridge/instrument-calculate-max
Jul 30, 2026
Merged

bridge: instrument calculateMaxForBridge#226
Makyl merged 1 commit into
mainfrom
bridge/instrument-calculate-max

Conversation

@Makyl

@Makyl Makyl commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR instruments calculateMaxForBridge through the SDK's standard public-operation boundary.

Bridge max calculations now emit initiated, success, failure, and performance analytics, while failures are reported to OTel with the correct public operation name. The existing public method signature, result shape, and error behavior remain unchanged.

Changes

  • Add the calculateMaxForBridge analytics lifecycle triplet and stable performance operation label.
  • Add calculateMaxForBridge to the exported OTel OperationName union.
  • Route the public client method through a typed operation-boundary wrapper with destination, token, and source-chain context.
  • Add focused client coverage for success, failure, performance naming, OTel operation naming, and result/error preservation.
  • Extend the public analytics taxonomy lock and operation-name type-surface assertion.
  • Add the existing bridge-max method to the architecture's public-client inventory.

Testing

  • npm test
  • npm run typecheck
  • npm run lint

Risk / Impact

  • The exported analytics taxonomy and OperationName union are extended additively.
  • calculateMaxForBridge now emits the lifecycle telemetry already used by other public operations.
  • No NexusClient method signature, bridge-max calculation, result shape, or thrown error changes.
  • Error details remain exclusive to OTel and are not added to PostHog failure payloads.

@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nexus-sdk Ready Ready Preview, Comment Jul 29, 2026 3:33pm

Request Review

@Makyl
Makyl merged commit 9023e0b into main Jul 30, 2026
3 checks passed
@Makyl
Makyl deleted the bridge/instrument-calculate-max branch July 30, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants