bridge: instrument calculateMaxForBridge - #226
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
shrinathprabhu
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR instruments
calculateMaxForBridgethrough the SDK's standard public-operation boundary.Bridge max calculations now emit initiated, success, failure, and performance analytics, while failures are reported to OTel with the correct public operation name. The existing public method signature, result shape, and error behavior remain unchanged.
Changes
calculateMaxForBridgeanalytics lifecycle triplet and stable performance operation label.calculateMaxForBridgeto the exported OTelOperationNameunion.Testing
npm testnpm run typechecknpm run lintRisk / Impact
OperationNameunion are extended additively.calculateMaxForBridgenow emits the lifecycle telemetry already used by other public operations.NexusClientmethod signature, bridge-max calculation, result shape, or thrown error changes.