Fix UnboundLocalError for all_mappings in run_pdm_score.py - #193
Open
dhruvildarji wants to merge 1 commit into
Open
Fix UnboundLocalError for all_mappings in run_pdm_score.py#193dhruvildarji wants to merge 1 commit into
dhruvildarji wants to merge 1 commit into
Conversation
Initialize `all_mappings = {}` in the except block so that when
`reactive_all_mapping` config key is missing, the variable is still
defined for downstream usage in `calculate_individual_mapping_scores`.
Fixes autonomousvision#182
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UnboundLocalError: local variable 'all_mappings' referenced before assignmentinrun_pdm_score.pyreactive_all_mappingconfig key is missing, theexceptblock now initializesall_mappings = {}so downstream code (calculate_individual_mapping_scores) doesn't crashFixes #182
Changes
In
navsim/planning/script/run_pdm_score.py, addedall_mappings = {}to theexceptblock (line 386) that handles the missingreactive_all_mappingconfiguration key. Previously,all_mappingswas only assigned inside thetryblock, causing anUnboundLocalErrorwhen the exception path was taken.Test plan
run_pdm_score.pywith a split that lacksreactive_all_mapping(e.g.,navtest_two_stage) and confirm it completes without crashing