docs(fdw): fix has_permission filter examples - #3237
Open
capybara-alt wants to merge 1 commit into
Open
Conversation
Member
Is this being added solely to make sure the "missing caveat context" results are not included? |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3236
The documented
AND has_permission = trueexamples fail when run: Postgresfolds
= trueinto a bare column reference before pushdown, and the proxyrejects
has_permissionin WHERE clauses.Changes
README.md: usehas_permission IS truein the Lookup Resources / LookupSubjects examples —
IS TRUEis not pushed down by postgres_fdw and getsevaluated locally, so the query works as intended.
Architecture.md: drop thehas_permissioncondition from thehandler-dispatch and cursor examples entirely — these show SQL as received
by the proxy, where no local filtering exists and neither form is supported.
Testing
Verified against a live setup (SpiceDB + FDW proxy + Postgres 17 with
postgres_fdw): the original examples fail with
operation not supported: column_ref, the updated README examples return the expected rows(
EXPLAIN VERBOSEconfirmsIS TRUEbecomes a localFilternode), and theupdated Architecture.md queries dispatch to LookupResources/LookupSubjects.