chore: add retries to read path in postgres datastore impl - #3223
Open
tstirrat15 wants to merge 1 commit into
Open
chore: add retries to read path in postgres datastore impl#3223tstirrat15 wants to merge 1 commit into
tstirrat15 wants to merge 1 commit into
Conversation
tstirrat15
marked this pull request as ready for review
July 10, 2026 15:45
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 1af38ab | Previous: cbdf06c | Ratio |
|---|---|---|---|
BenchmarkDatastoreDriver/cockroachdb-overlap-static/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) |
35925563 ns/op 174908 B/op 20200 allocs/op |
6805173 ns/op 172708 B/op 20195 allocs/op |
5.28 |
BenchmarkDatastoreDriver/cockroachdb-overlap-static/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op |
35925563 ns/op |
6805173 ns/op |
5.28 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) |
32436578 ns/op 173664 B/op 20197 allocs/op |
6853237 ns/op 172793 B/op 20195 allocs/op |
4.73 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/SnapshotReverseRead (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op |
32436578 ns/op |
6853237 ns/op |
4.73 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Touch (github.com/authzed/spicedb/internal/datastore/benchmark) |
6044648 ns/op 22170 B/op 287 allocs/op |
2857511 ns/op 22094 B/op 287 allocs/op |
2.12 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Touch (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op |
6044648 ns/op |
2857511 ns/op |
2.12 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Create (github.com/authzed/spicedb/internal/datastore/benchmark) |
6124342 ns/op 19543 B/op 281 allocs/op |
2004369 ns/op 19414 B/op 281 allocs/op |
3.06 |
BenchmarkDatastoreDriver/cockroachdb-overlap-insecure/TestTuple/Create (github.com/authzed/spicedb/internal/datastore/benchmark) - ns/op |
6124342 ns/op |
2004369 ns/op |
3.06 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was identified as a part of trying to fix a flaky test. The idea is that if the postgres driver gets a network-level error on a read, it should be retryable; we previously weren't retrying these. It should theoretically slightly improve read resiliency.
Changes
Testing
Review.