fix(streamtimeout): exempt bulk export/import methods - #3143
Open
ivanauth wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
area/api v1
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ivanauth
force-pushed
the
fix/exempt-bulk-export-from-streamtimeout
branch
from
June 5, 2026 23:00
be4ad12 to
c4cb74c
Compare
ivanauth
force-pushed
the
fix/exempt-bulk-export-from-streamtimeout
branch
3 times, most recently
from
June 29, 2026 19:00
0a289b6 to
31c2837
Compare
ivanauth
force-pushed
the
fix/exempt-bulk-export-from-streamtimeout
branch
from
July 1, 2026 19:51
31c2837 to
8f82315
Compare
ivanauth
force-pushed
the
fix/exempt-bulk-export-from-streamtimeout
branch
from
July 1, 2026 19:58
8f82315 to
31c2837
Compare
ivanauth
force-pushed
the
fix/exempt-bulk-export-from-streamtimeout
branch
from
July 13, 2026 14:24
31c2837 to
9a2a70d
Compare
ivanauth
force-pushed
the
fix/exempt-bulk-export-from-streamtimeout
branch
from
July 24, 2026 17:49
9a2a70d to
14e04c8
Compare
tstirrat15
force-pushed
the
fix/exempt-bulk-export-from-streamtimeout
branch
from
August 4, 2026 21:18
9371e98 to
5b2b3c6
Compare
miparnisari
reviewed
Aug 5, 2026
| streamtimeout.MustStreamServerInterceptor( | ||
| config.StreamReadTimeout, | ||
| // Bulk export/import are designed to run for arbitrarily long | ||
| // periods on large datasets; their inter-batch gaps regularly |
Contributor
There was a problem hiding this comment.
i'm curious about these inter-batch gaps? why do they happen?
Signed-off-by: ivanauth <ivan@authzed.com>
…ing it Messages received from the client now reset the stream timeout, so the timeout bounds inactivity rather than the total duration of a call. Bulk import is therefore no longer capped at the streaming-api timeout regardless of how actively the client is sending, and because the timer stops once the client half-closes, committing the import is not bounded either. Bulk import is no longer exempt: it holds an open write transaction with retries disabled for the life of the stream, so removing every server-side bound on it is not worth the write-pool exposure. Bulk export stays exempt, since it sends one batch per datastore page and holds no transaction or connection in between. Also corrects the flag help text, which still listed ExportBulkRelationships as covered, in both serve.go and the checked-in docs/spicedb.md that the docs workflow publishes. Tests cover the client-streaming shape that regressed, and a single interceptor with one exempt and one non-exempt method to catch an over-broad exemption.
ivanauth
force-pushed
the
fix/exempt-bulk-export-from-streamtimeout
branch
from
August 6, 2026 19:36
31817be to
a9f87e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The streaming-timeout interceptor cancels a stream if the server is silent for
StreamingAPITimeout(default 30s), assuming a hung client. Bulk export/import legitimately go silent for long stretches between batches on large datasets, so the interceptor was cancelling healthy streams (clients sawRST_STREAM NO_ERROR).Add
WithExemptMethodsto the interceptor and exempt:PermissionsService/ExportBulkRelationshipsPermissionsService/ImportBulkRelationshipsExperimentalService/BulkExportRelationshipsExperimentalService/BulkImportRelationshipsAll other streaming methods keep the timeout.