Fe/v2 - #1196
Open
eduardoliron wants to merge 223 commits into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ay timers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…Hide guard Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
## 👋 Intro As suggested, migrated code from a chip on the top bar to an input field where it is required ## 🕵️ Context Added code as an input and updated tests ## 📋 Checklist <!-- If any of the items is deliberately skipped, fill in the checkbox with `/` or `-` and include explanation for why --> - [x] Tested manually - [ ] Added e2e tests for new functionality - [ ] GitHub issue linked <!-- Use the "Development" field of the Issue, or add a link if it's outside this Repo --> - [ ] Changelist updated - [x] Backward and forward compatible with [aula-backend/releases](https://github.com/aula-app/aula-backend/releases) <!-- If not, please describe in detail and include other PR links --> - [x] Doesn't need update in the database or BE <!-- If it does, please describe how to deploy it without downtime --> - [ ] Must be deployed ASAP (HOTFIX) - [ ] Needs update of [docs.aula.de](https://docs.aula.de/) ([repo](https://github.com/leonard-haas/docs_aula)) <!-- If it does, please ping Leonard OR include link to the change in the docs repo --> ## 📸 Screenshot <!-- Add a screenshot (if possible). --> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
🤖 Resolves #1171 ## 👋 Intro Refactor AskConsent component to a V2 Announcement component ## 🕵️ Context New components: - [x] Dialog (Generic) - [x] Announcement (Specific) Updated components: - [x] Button -> small fix: Outlined buttons where bigger than the default ones Reviewed/updated tests: - [x] Announcements.spec ## 📋 Checklist <!-- If any of the items is deliberately skipped, fill in the checkbox with `/` or `-` and include explanation for why --> - [x] Tested manually - [x] Added e2e tests for new functionality - [x] GitHub issue linked <!-- Use the "Development" field of the Issue, or add a link if it's outside this Repo --> - [x] Changelist updated - [x] Backward and forward compatible with [aula-backend/releases](https://github.com/aula-app/aula-backend/releases) <!-- If not, please describe in detail and include other PR links --> - [x] Doesn't need update in the database or BE <!-- If it does, please describe how to deploy it without downtime --> - [ ] Must be deployed ASAP (HOTFIX) - [ ] Needs update of [docs.aula.de](https://docs.aula.de/) ([repo](https://github.com/leonard-haas/docs_aula)) <!-- If it does, please ping Leonard OR include link to the change in the docs repo --> ## 📸 Screenshot <!-- Add a screenshot (if possible). --> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
## 👋 Intro Review the Room layout and the phase bar component ## 🕵️ Context Review colors, accessibility and strubutre of base component for room navigation ## 📋 Checklist <!-- If any of the items is deliberately skipped, fill in the checkbox with `/` or `-` and include explanation for why --> - [x] Tested manually - [ ] Added e2e tests for new functionality - [ ] GitHub issue linked <!-- Use the "Development" field of the Issue, or add a link if it's outside this Repo --> - [ ] Changelist updated - [x] Backward and forward compatible with [aula-backend/releases](https://github.com/aula-app/aula-backend/releases) <!-- If not, please describe in detail and include other PR links --> - [x] Doesn't need update in the database or BE <!-- If it does, please describe how to deploy it without downtime --> - [ ] Must be deployed ASAP (HOTFIX) - [ ] Needs update of [docs.aula.de](https://docs.aula.de/) ([repo](https://github.com/leonard-haas/docs_aula)) <!-- If it does, please ping Leonard OR include link to the change in the docs repo --> ## 📸 Screenshot <!-- Add a screenshot (if possible). --> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
leonard-haas
approved these changes
Jun 25, 2026
Contributor
|
re-re-reviewed latest round of checkmarks looks good, ios scrolling feels nice!
lmk if you'd prefer this as a new issue |
🤖 Resolves issue #1173 ## 👋 Intro Migration of Wild Ideas View for V2 ## 🕵️ Context This is a migration of the wild-idea view. WIP: Search and Sort will be updated in a separate branch, to simplify review process (private/ideas-search-and-sort) ## 🤔 What is new? - Room child pages template (Created as a reusable template) - Wild Ideas view - Idea component - User info and creation date component - Like button - Comments button - Idea "bubble" layout - New Idea creation form (using tailwind components) ## 🧐 New tests - Added Vitest for unit testing: - Scroll restoration hook - useDraftStorage hook - useIdeaLike hook - Emoji rendes on ideas and form edits - Updated e2e tests - Added e2e tests: - Idea draft persistence (inside idea.spec) - More-options panel behavior (inside idea.spec) - Like flow (inside idea.spec) - Idea edit flow (inside idea.spec) - Ideas page states: empty, FAB hidden, etc. (inside idea.spec) ## 📋 Checklist <!-- If any of the items is deliberately skipped, fill in the checkbox with `/` or `-` and include explanation for why --> - [x] Tested manually - [x] Added e2e tests for new functionality - [x] GitHub issue linked <!-- Use the "Development" field of the Issue, or add a link if it's outside this Repo --> - [ ] Changelist updated - [x] Backward and forward compatible with [aula-backend/releases](https://github.com/aula-app/aula-backend/releases) <!-- If not, please describe in detail and include other PR links --> - [x] Doesn't need update in the database or BE <!-- If it does, please describe how to deploy it without downtime --> - [ ] Must be deployed ASAP (HOTFIX) - [ ] Needs update of [docs.aula.de](https://docs.aula.de/) ([repo](https://github.com/leonard-haas/docs_aula)) <!-- If it does, please ping Leonard OR include link to the change in the docs repo --> ## 📸 Screenshot <!-- Add a screenshot (if possible). --> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
nikola-maric-aula
force-pushed
the
FE/v2
branch
from
August 3, 2026 13:59
06e3570 to
1fd8de2
Compare
🤖 Resolves <!-- issue # --> ## 👋 Intro Use new docker networks setup. ## 🕵️ Context Follow up to this: https://github.com/aula-app/ansible-role-aula/pull/6/changes ## 📋 Checklist <!-- If any of the items is deliberately skipped, fill in the checkbox with `/` or `-` and include explanation for why --> - [ ] Tested manually - [/] Added e2e tests for new functionality - [/] GitHub issue linked <!-- Use the "Development" field of the Issue, or add a link if it's outside this Repo --> - [/] Changelist updated - [/] Backward and forward compatible with [aula-backend/releases](https://github.com/aula-app/aula-backend/releases) <!-- If not, please describe in detail and include other PR links --> - [/] Doesn't need update in the database or BE <!-- If it does, please describe how to deploy it without downtime --> - [ ] Must be deployed ASAP (HOTFIX) - [ ] Needs update of [docs.aula.de](https://docs.aula.de/) ([repo](https://github.com/leonard-haas/docs_aula)) <!-- If it does, please ping Leonard OR include link to the change in the docs repo --> ## 📸 Screenshot <!-- Add a screenshot (if possible). -->
🤖 Resolves #1172 ## 👋 Intro Migration of the Idea-Box (Boxes) View for V2 ## 🕵️ Context This is a migration of the Room phase page that lists idea-boxes. It also generalizes the idea-specific action components (MoreOptions + Edit/Delete/ Report/Share buttons) into reusable components now shared by both Ideas and Boxes, and introduces the box create/edit and report forms with Tailwind. ## 🤔 What is new? - **Boxes view** (v2 Room child page): lists boxes for the current phase - Loading, error, empty, and no-results states - FAB to add a box - Search & sort (extended `useListFilter` with box options: last update, name, ideas count) - **BoxCard** component - Phase header + ideas count - Per-card actions via MoreOptions: Edit, Delete, Report, Share - Markdown description preview - **BoxForm** (create/edit box, Tailwind) - **ReportForm** (generic, Tailwind — reason select + rich-text content) - **PhaseField** form field - **Generic, reusable components** (extracted from idea-specific ones): - `ui/MoreOptions` (was `idea/MoreOptions`) — now takes `menuTestId`/`panelTestId` - `button/EditButton`, `button/DeleteButton`, `button/ReportButton`, `button/ShareButton` (renamed from the `*IdeaButton` variants; Idea now consumes these too) - Localization keys added for report reasons, box form, phases, and sort labels (de/en) ## 🧐 New tests - **Updated e2e** to drive the migrated v2 components: - `boxes.spec.ts` — box-list assertions now target the v2 card (`box-{name}`) - `voting-workflow.spec.ts` — box-list assertions across DISCUSSION/APPROVAL/VOTING/RESULTS phases - `reporting.ts` interactions — idea reporting now uses the v2 `ReportForm` (comment reporting intentionally kept on the v1 form, which hasn't migrated) - Type check + existing Vitest suite green > Follow-ups (not in this PR): e2e for the v2 box **card** create/edit/delete/share > flow (still exercised via the v1 Settings page), a `boxes-search-and-sort` spec, > and unit tests for the generic `MoreOptions` / `BoxForm` / `ReportForm`. ## 📋 Checklist <!-- If any of the items is deliberately skipped, fill in the checkbox with `/` or `-` and include explanation for why --> - [x] Tested manually - [x] Added e2e tests for new functionality - [x] GitHub issue linked <!-- Use the "Development" field of the Issue, or add a link if it's outside this Repo --> - [ ] Changelist updated - [x] Backward and forward compatible with [aula-backend/releases](https://github.com/aula-app/aula-backend/releases) <!-- If not, please describe in detail and include other PR links --> - [x] Doesn't need update in the database or BE <!-- If it does, please describe how to deploy it without downtime --> - [ ] Must be deployed ASAP (HOTFIX) - [ ] Needs update of [docs.aula.de](https://docs.aula.de/) ([repo](https://github.com/leonard-haas/docs_aula)) <!-- If it does, please ping Leonard OR include link to the change in the docs repo --> ## 📸 Screenshot <!-- Add a screenshot (if possible). --> --------- Co-authored-by: nikola-maric-aula <nikola.maric@aula.de>
🤖 Resolves <!-- issue # --> ## 👋 Intro ## 🕵️ Context This feature was missing from private/boxes PR ## 📋 Checklist <!-- If any of the items is deliberately skipped, fill in the checkbox with `/` or `-` and include explanation for why --> - [ ] Tested manually - [ ] Added e2e tests for new functionality - [ ] GitHub issue linked <!-- Use the "Development" field of the Issue, or add a link if it's outside this Repo --> - [ ] Changelist updated - [ ] Backward and forward compatible with [aula-backend/releases](https://github.com/aula-app/aula-backend/releases) <!-- If not, please describe in detail and include other PR links --> - [ ] Doesn't need update in the database or BE <!-- If it does, please describe how to deploy it without downtime --> - [ ] Must be deployed ASAP (HOTFIX) - [ ] Needs update of [docs.aula.de](https://docs.aula.de/) ([repo](https://github.com/leonard-haas/docs_aula)) <!-- If it does, please ping Leonard OR include link to the change in the docs repo --> ## 📸 Screenshot <!-- Add a screenshot (if possible). --> --------- Co-authored-by: nikola-maric-aula <nikola.maric@aula.de>
## 👋 Intro V2 breadcrumb navigations was losing phase when navigating back to room ## 🕵️ Context Navigate to a box, go back to the room using breadcrumbs, the phase should persist ## 📋 Checklist <!-- If any of the items is deliberately skipped, fill in the checkbox with `/` or `-` and include explanation for why --> - [x] Tested manually - [ ] Added e2e tests for new functionality - [ ] GitHub issue linked <!-- Use the "Development" field of the Issue, or add a link if it's outside this Repo --> - [ ] Changelist updated - [ ] Backward and forward compatible with [aula-backend/releases](https://github.com/aula-app/aula-backend/releases) <!-- If not, please describe in detail and include other PR links --> - [ ] Doesn't need update in the database or BE <!-- If it does, please describe how to deploy it without downtime --> - [ ] Must be deployed ASAP (HOTFIX) - [ ] Needs update of [docs.aula.de](https://docs.aula.de/) ([repo](https://github.com/leonard-haas/docs_aula)) <!-- If it does, please ping Leonard OR include link to the change in the docs repo --> ## 📸 Screenshot <!-- Add a screenshot (if possible). -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Resolves #1156 , #1160 and #1168
👋 Intro
Review of private FE pages for improvements on several directions that are blocking development:
This PR is migrating the basic private infrastructure
🕵️ Context
Updates:
New pages:
New components:
New tests:
🧾 Migration Checklist
🤔 Open questions after BE migration
📋 Checklist
📸 Screenshots