Updates the ICM peripheral to use the clock::v2 API - #927
Merged
Conversation
Contributor
|
Looks good to me! Appreciate the documentation updates as well. |
ianrrees
reviewed
Jul 20, 2025
ianrrees
left a comment
ianrrees
left a comment
Contributor
There was a problem hiding this comment.
Just a minor naming suggestion, but otherwise LGTM
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Jul 21, 2025
…in the `Icm` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Jul 21, 2025
…in the `Dsu` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Jul 21, 2025
…in the `Dsu` struct per the recommendation in PR atsamd-rs#927.
Contributor
Author
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Jul 30, 2025
…in the `Dsu` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Aug 4, 2025
…in the `Icm` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Aug 13, 2025
…in the `Dsu` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Aug 13, 2025
…in the `Icm` struct per the recommendation in PR atsamd-rs#927.
sajattack
pushed a commit
to kyp44/atsamd
that referenced
this pull request
Sep 30, 2025
…in the `Dsu` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Oct 1, 2025
…in the `Icm` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Oct 15, 2025
…in the `Dsu` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Oct 15, 2025
…in the `Icm` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Oct 29, 2025
…in the `Dsu` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Oct 29, 2025
…in the `Icm` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Nov 12, 2025
…in the `Dsu` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Nov 12, 2025
…in the `Icm` struct per the recommendation in PR atsamd-rs#927.
kyp44
added a commit
to kyp44/atsamd
that referenced
this pull request
Nov 24, 2025
…in the `Dsu` struct per the recommendation in PR atsamd-rs#927.
* `Icm::new` now requires ownership of its `AhbClk` and `ApbClk`.
* Renames `Icm::destroy` to the standard `Icm::free` method to free the `pac::Icm` and bus clocks.
* Updates the `icm` module documentation example to include the above changes.
…in the `Icm` struct per the recommendation in PR atsamd-rs#927.
jbeaurivage
pushed a commit
that referenced
this pull request
Jun 2, 2026
* feat(icm): Migrates the `icm::Icm` peripheral to use the `clock::v2`.
* `Icm::new` now requires ownership of its `AhbClk` and `ApbClk`.
* Renames `Icm::destroy` to the standard `Icm::free` method to free the `pac::Icm` and bus clocks.
* Updates the `icm` module documentation example to include the above changes.
* feat(icm): Removes the underscores from the owned AHB and APB clocks in the `Icm` struct per the recommendation in PR #927.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of the
clock::v2effort tracked in Issue #912, this PR updates theicmto use theclock::v2API by requiring ownership of itsAhbClkandApbClk. Note that this peripheral is only onthumbv7targets.No examples on any Tier 1 BSPs use the ICM so none were affected.
Checklist
#[allow]certain lints where reasonable, but ideally justify those with a short comment.