fix: add workspaces field for yarn CI compatibility - #2
Open
CoderSerio wants to merge 5 commits into
Open
CoderSerio wants to merge 5 commits into
CoderSerio wants to merge 5 commits into
Conversation
- Add workspaces array to package.json - Update repository URL to atom-universe/FeOPack - This allows Yarn CI to properly resolve workspace packages
- Add --no-immutable flag to all yarn install commands - This allows lockfile updates during CI when package.json changes
- Add 'build' script that runs napi build --platform --release - CI calls 'yarn build --target <triple>' which now works
- Change cache from yarn to pnpm - Replace yarn install with pnpm install - Replace yarn build with pnpm build - Replace yarn lint with pnpm lint - Remove yarn-specific configurations
- Add pnpm/action-setup@v4 to install pnpm before use - Required because pnpm is not pre-installed on GitHub runners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI fails at
yarn installstep because Yarn cannot resolve workspace packages.Root cause:
pnpm-workspace.yaml(for pnpm)package.jsonmissingworkspacesfield (required by Yarn)Solution
Add
workspacesfield topackage.json:{ "workspaces": [ "packages/*", "crates/node-binding" ] }This allows both pnpm and Yarn to properly resolve workspace packages.
Additional Changes
napi-rs/package-templatetoatom-universe/FeOPackTesting
CI should now pass the
yarn installstep and proceed to build/test.