Prevent Jira hover lookups for date-like strings - #1924
Open
Shankar-v27 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Shankar V <shankarvelmurugan2018@gmail.com>
Shankar-v27
requested review from
Blastoplex,
amarg-at,
bwieger-atlassian-com,
cabella-dot,
ccallcottstevens,
cindy-atl,
dchiew-atl,
jwang19-atlassian,
leandrowd,
marcomura,
matt-lassian,
mattcolman,
sdzh-atlassian and
teg-atlassian
as code owners
August 5, 2026 05:35
|
Hooray! All contributors have signed the CLA. |
Contributor
|
To enable Rovo Dev code reviews, link your GitHub account to your Atlassian account. This is a one-time task that takes less than a minute. Once your account is linked, resubmit the pull request to trigger a code review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Is This Change?
Fixes #1921.
When Jira hover is enabled, hovering over date-like strings such as
2026-08currently triggers unnecessary Jira lookups because they matchIssueKeyRegEx.This change adds a localized guard in
IssueHoverProviderto skip hover lookups forYYYY-MMdate-like strings before callingissueForKey().The change intentionally leaves
IssueKeyRegExunchanged so existing issue-key parsing behavior (including numeric project identifiers) is preserved.How Has This Been Tested?
Added unit tests covering:
2026-08does not trigger a Jira lookup2026-08-05does not trigger a Jira lookupABC-123continues to trigger a Jira lookup123-456continues to trigger a Jira lookupRan the relevant unit tests locally.
npm run testnpm run lintRovo Dev code review: Rovo Dev couldn't review this pull request
The pull request author does not have access to Rovo Dev.